[jira] Commented: (COUCHDB-862) replicator.js fails to run in standalone js tests

["Filipe Manana (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900281#action_12900281 ] 

Filipe Manana commented on COUCHDB-862:
---------------------------------------

Bob, thanks for the patch.

The use of those jQuery functions is actually my fault.

I looked at the patch and have the following remarks:

1)  don't do   toString.call(repResult.history) === "[object Array]"
     do instead   repResult.history instanceof Array

2) the replacement for $.inArray  would be array.indexOf(element)  (return value -1 means not found, else found)
    therefore avoiding those for loops to search for the element

thanks

> replicator.js fails to run in standalone js tests
> -------------------------------------------------
>
>                 Key: COUCHDB-862
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-862
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Test Suite
>         Environment: OS X
>            Reporter: Bob Dionne
>            Priority: Trivial
>         Attachments: replicator.js.patch
>
>
> replicator.js uses some jQuery functions such as jQuery.each and inArray, which causes it to fail when tests are run outside the browser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.