[jira] [Commented] (CAY-1873) Move DataDomain cache configuration from the Modeler and into DI

["Andrus Adamchik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAY-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902371#comment-13902371 ] 

Andrus Adamchik commented on CAY-1873:
--------------------------------------

Hi Oleg, Just reviewed cay1873.patch patch. IMO the approach looks sound and we should go with it. Just a few minor notes on our coding conventions (nothing related to the code essence ) :

1. Missing license headers in the new classes. You can add those to Eclipse template to never forget it again.
2. Add @since 3.2 to all the new public classes. Also to the new methods of the existing classes
3. All the removed public constants should be preserved, but  be marked as "@deprecated since 3.2 (explanation)". Same goes for removed methods, except when we can't provide a reasonable replacement that works with the rest if the code (in such case the method can be removed).



> Move DataDomain cache configuration from the Modeler and into DI
> ----------------------------------------------------------------
>
>                 Key: CAY-1873
>                 URL: https://issues.apache.org/jira/browse/CAY-1873
>             Project: Cayenne
>          Issue Type: Task
>            Reporter: Andrus Adamchik
>            Assignee: Andrus Adamchik
>         Attachments: cay1873.patch, cay1873_modeler.patch, cay1873_test.patch, x.png
>
>
> Cache configuration for DataDomain is currently done in the Modeler. (this configuration is limited to the "object cache" [1], query cache is configured in DI already)  and this seems misplaced. Cache settings are highly environment dependent and are better managed by DI. So let's remove all these screens from the Modeler and create any needed DI services that perform this configuration function.
> (The next step, outside the scope of this Jira, may be combining query cache and object cache in the same cache engine)
> [1] http://cayenne.apache.org/docs/3.0/caching-and-fresh-data.html



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)