You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stdcxx.apache.org by Martin Sebor <se...@roguewave.com> on 2008/05/06 21:48:39 UTC
Re: svn commit: r647262 - /stdcxx/trunk/tests/localization/22.locale.num.get.cpp
vitek@apache.org wrote:
> Author: vitek
> Date: Fri Apr 11 11:41:51 2008
> New Revision: 647262
>
> URL: http://svn.apache.org/viewvc?rev=647262&view=rev
> Log:
>
> 2008-04-11 Travis Vitek <vi...@roguewave.com>
>
> STDCXX-779
> * tests/localization/22.locale.num.get.cpp: Add new macro T_MAX to
> eliminate potential for accessing local variable via pointer after
> it has gone out of scope. Remove global pointer pmax.
Can we make the local variable static instead of all these
changes? (Global or local, we do want to keep the comment
about the purpose of pval).
> (do_test): Add new pointer parameter pmax.
> (test_flt_uflow): Use new T_MAX macro.
> (test_dbl_uflow): Ditto.
> (test_ldbl_uflow): Ditto.
Martin
RE: svn commit: r647262 - /stdcxx/trunk/tests/localization/22.locale.num.get.cpp
Posted by Travis Vitek <Tr...@roguewave.com>.
>Martin Sebor
>
>vitek@apache.org wrote:
>> Author: vitek
>> Date: Fri Apr 11 11:41:51 2008
>> New Revision: 647262
>>
>> URL: http://svn.apache.org/viewvc?rev=647262&view=rev
>> Log:
>>
>> 2008-04-11 Travis Vitek <vi...@roguewave.com>
>>
>> STDCXX-779
>> * tests/localization/22.locale.num.get.cpp: Add new macro
>> T_MAX to eliminate potential for accessing local variable
>> via pointer after it has gone out of scope. Remove global
>> pointer pmax.
>
>Can we make the local variable static instead of all these
>changes? (Global or local, we do want to keep the comment
>about the purpose of pval).
Committed to 4.2.x as r653965.
>
>> (do_test): Add new pointer parameter pmax.
>> (test_flt_uflow): Use new T_MAX macro.
>> (test_dbl_uflow): Ditto.
>> (test_ldbl_uflow): Ditto.
>
>Martin
>
RE: svn commit: r647262 - /stdcxx/trunk/tests/localization/22.locale.num.get.cpp
Posted by Travis Vitek <Tr...@roguewave.com>.
>Martin Sebor wrote:
>
>vitek@apache.org wrote:
>> Author: vitek
>> Date: Fri Apr 11 11:41:51 2008
>> New Revision: 647262
>>
>> URL: http://svn.apache.org/viewvc?rev=647262&view=rev
>> Log:
>>
>> 2008-04-11 Travis Vitek <vi...@roguewave.com>
>>
>> STDCXX-779
>> * tests/localization/22.locale.num.get.cpp: Add new
>macro T_MAX to
>> eliminate potential for accessing local variable via
>pointer after
>> it has gone out of scope. Remove global pointer pmax.
>
>Can we make the local variable static instead of all these
>changes? (Global or local, we do want to keep the comment
>about the purpose of pval).
>
I can't believe I didn't think of that! How silly of me. I'll go back
and make the simpler change.
>> (do_test): Add new pointer parameter pmax.
>> (test_flt_uflow): Use new T_MAX macro.
>> (test_dbl_uflow): Ditto.
>> (test_ldbl_uflow): Ditto.
>
>Martin
>