You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ch...@apache.org on 2015/04/08 04:39:05 UTC
svn commit: r1671994 -
/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java
Author: chas
Date: Wed Apr 8 02:39:05 2015
New Revision: 1671994
URL: http://svn.apache.org/r1671994
Log:
LANG-1111 - Fix FindBugs warnings in DurationFormatUtils
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java?rev=1671994&r1=1671993&r2=1671994&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java Wed Apr 8 02:39:05 2015
@@ -433,25 +433,25 @@ public class DurationFormatUtils {
if (value instanceof StringBuilder) {
buffer.append(value.toString());
} else {
- if (value == y) {
+ if (value.equals(y)) {
buffer.append(paddedValue(years, padWithZeros, count));
lastOutputSeconds = false;
- } else if (value == M) {
+ } else if (value.equals(M)) {
buffer.append(paddedValue(months, padWithZeros, count));
lastOutputSeconds = false;
- } else if (value == d) {
+ } else if (value.equals(d)) {
buffer.append(paddedValue(days, padWithZeros, count));
lastOutputSeconds = false;
- } else if (value == H) {
+ } else if (value.equals(H)) {
buffer.append(paddedValue(hours, padWithZeros, count));
lastOutputSeconds = false;
- } else if (value == m) {
+ } else if (value.equals(m)) {
buffer.append(paddedValue(minutes, padWithZeros, count));
lastOutputSeconds = false;
- } else if (value == s) {
+ } else if (value.equals(s)) {
buffer.append(paddedValue(seconds, padWithZeros, count));
lastOutputSeconds = true;
- } else if (value == S) {
+ } else if (value.equals(S)) {
if (lastOutputSeconds) {
// ensure at least 3 digits are displayed even if padding is not selected
final int width = padWithZeros ? Math.max(3, count) : 3;
@@ -551,7 +551,7 @@ public class DurationFormatUtils {
}
if (value != null) {
- if (previous != null && previous.getValue() == value) {
+ if (previous != null && previous.getValue().equals(value)) {
previous.increment();
} else {
final Token token = new Token(value);