You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Sian January (JIRA)" <ji...@apache.org> on 2007/09/04 15:02:47 UTC
[jira] Created: (HARMONY-4734) [classlib] [pack200] Pack200 - Some
refactoring
[classlib] [pack200] Pack200 - Some refactoring
-----------------------------------------------
Key: HARMONY-4734
URL: https://issues.apache.org/jira/browse/HARMONY-4734
Project: Harmony
Issue Type: Improvement
Components: Classlib
Reporter: Sian January
Priority: Minor
I have done some refactoring in pack200 to break down the main Segment class into several more manageable sized classes. The various parseXXX methods in Segment have been factored out into some new classes that are each responsible for parsing and holding the data for a particular set of bands in the pack200 archive. These new classes have a common superclass - BandSet.
This patch doesn't change the implementation at all except for adding a couple of extra tests, but it's quite large due to the size of the class being refactored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4734) [classlib] [pack200] Pack200 - Some
refactoring
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin closed HARMONY-4734.
----------------------------------
Verified - closing...
> [classlib] [pack200] Pack200 - Some refactoring
> -----------------------------------------------
>
> Key: HARMONY-4734
> URL: https://issues.apache.org/jira/browse/HARMONY-4734
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Sian January
> Assignee: Oliver Deakin
> Priority: Minor
> Attachments: pack200.patch
>
>
> I have done some refactoring in pack200 to break down the main Segment class into several more manageable sized classes. The various parseXXX methods in Segment have been factored out into some new classes that are each responsible for parsing and holding the data for a particular set of bands in the pack200 archive. These new classes have a common superclass - BandSet.
> This patch doesn't change the implementation at all except for adding a couple of extra tests, but it's quite large due to the size of the class being refactored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4734) [classlib] [pack200] Pack200 -
Some refactoring
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524773 ]
Sian January commented on HARMONY-4734:
---------------------------------------
Thanks Oli - the patch was applied as expected.
> [classlib] [pack200] Pack200 - Some refactoring
> -----------------------------------------------
>
> Key: HARMONY-4734
> URL: https://issues.apache.org/jira/browse/HARMONY-4734
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Sian January
> Assignee: Oliver Deakin
> Priority: Minor
> Attachments: pack200.patch
>
>
> I have done some refactoring in pack200 to break down the main Segment class into several more manageable sized classes. The various parseXXX methods in Segment have been factored out into some new classes that are each responsible for parsing and holding the data for a particular set of bands in the pack200 archive. These new classes have a common superclass - BandSet.
> This patch doesn't change the implementation at all except for adding a couple of extra tests, but it's quite large due to the size of the class being refactored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4734) [classlib] [pack200] Pack200 - Some
refactoring
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January updated HARMONY-4734:
----------------------------------
Attachment: pack200.patch
> [classlib] [pack200] Pack200 - Some refactoring
> -----------------------------------------------
>
> Key: HARMONY-4734
> URL: https://issues.apache.org/jira/browse/HARMONY-4734
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: pack200.patch
>
>
> I have done some refactoring in pack200 to break down the main Segment class into several more manageable sized classes. The various parseXXX methods in Segment have been factored out into some new classes that are each responsible for parsing and holding the data for a particular set of bands in the pack200 archive. These new classes have a common superclass - BandSet.
> This patch doesn't change the implementation at all except for adding a couple of extra tests, but it's quite large due to the size of the class being refactored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4734) [classlib] [pack200] Pack200 - Some
refactoring
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin resolved HARMONY-4734.
------------------------------------
Resolution: Fixed
Thanks Sian - patch applied at repo revision r572686. Please verify the patch applied correctly.
> [classlib] [pack200] Pack200 - Some refactoring
> -----------------------------------------------
>
> Key: HARMONY-4734
> URL: https://issues.apache.org/jira/browse/HARMONY-4734
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Sian January
> Assignee: Oliver Deakin
> Priority: Minor
> Attachments: pack200.patch
>
>
> I have done some refactoring in pack200 to break down the main Segment class into several more manageable sized classes. The various parseXXX methods in Segment have been factored out into some new classes that are each responsible for parsing and holding the data for a particular set of bands in the pack200 archive. These new classes have a common superclass - BandSet.
> This patch doesn't change the implementation at all except for adding a couple of extra tests, but it's quite large due to the size of the class being refactored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4734) [classlib] [pack200] Pack200 - Some
refactoring
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin reassigned HARMONY-4734:
--------------------------------------
Assignee: Oliver Deakin
> [classlib] [pack200] Pack200 - Some refactoring
> -----------------------------------------------
>
> Key: HARMONY-4734
> URL: https://issues.apache.org/jira/browse/HARMONY-4734
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Sian January
> Assignee: Oliver Deakin
> Priority: Minor
> Attachments: pack200.patch
>
>
> I have done some refactoring in pack200 to break down the main Segment class into several more manageable sized classes. The various parseXXX methods in Segment have been factored out into some new classes that are each responsible for parsing and holding the data for a particular set of bands in the pack200 archive. These new classes have a common superclass - BandSet.
> This patch doesn't change the implementation at all except for adding a couple of extra tests, but it's quite large due to the size of the class being refactored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.