You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Holger Hoffstätte (JIRA)" <ji...@apache.org> on 2006/10/30 13:43:18 UTC
[jira] Created: (POOL-88) Better maintenance of GKOP per-pool
activeCount
Better maintenance of GKOP per-pool activeCount
-----------------------------------------------
Key: POOL-88
URL: http://issues.apache.org/jira/browse/POOL-88
Project: Commons Pool
Issue Type: Improvement
Affects Versions: Nightly Builds
Reporter: Holger Hoffstätte
Priority: Minor
GenericKeyedObjectPool maintains a separate map for maintaining active object counts per key. IMHO it is better to put pool metadata together with the pool (queue).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (POOL-88) Better maintenance of GKOP per-pool
activeCount
Posted by "Holger Hoffstätte (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/POOL-88?page=all ]
Holger Hoffstätte updated POOL-88:
----------------------------------
Attachment: activeCount.patch
Patch for per-key/pool ObjectQueue "metadata" structure against svn trunk r469023. All related tests still pass.
> Better maintenance of GKOP per-pool activeCount
> -----------------------------------------------
>
> Key: POOL-88
> URL: http://issues.apache.org/jira/browse/POOL-88
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: Nightly Builds
> Reporter: Holger Hoffstätte
> Priority: Minor
> Attachments: activeCount.patch
>
>
> GenericKeyedObjectPool maintains a separate map for maintaining active object counts per key. IMHO it is better to put pool metadata together with the pool (queue).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (POOL-88) Better maintenance of GKOP per-pool
activeCount
Posted by "Holger Hoffstätte (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/POOL-88?page=comments#action_12445595 ]
Holger Hoffstätte commented on POOL-88:
---------------------------------------
Some more notes:
- class ObjectQueue is not static so that inc/decActiveCount can modify the global activeCount too.
- the only place where this lead to a bit of an odd situation was in invalidateObject(key, obj) where I now need to explicitly fetch the ObjectQueue even in case of an error so that the global counter can be decremented properly.
- I just saw that I erroneously marked the ObjectQueue instance variables as private, which of course has little effect on a nonstatic inner class.
> Better maintenance of GKOP per-pool activeCount
> -----------------------------------------------
>
> Key: POOL-88
> URL: http://issues.apache.org/jira/browse/POOL-88
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: Nightly Builds
> Reporter: Holger Hoffstätte
> Priority: Minor
> Attachments: activeCount.patch
>
>
> GenericKeyedObjectPool maintains a separate map for maintaining active object counts per key. IMHO it is better to put pool metadata together with the pool (queue).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Resolved: (POOL-88) Better maintenance of GKOP per-pool
activeCount
Posted by "Sandy McArthur (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/POOL-88?page=all ]
Sandy McArthur resolved POOL-88.
--------------------------------
Fix Version/s: Nightly Builds
Resolution: Fixed
I applied your patch with minimal changes. Much thanks.
> Better maintenance of GKOP per-pool activeCount
> -----------------------------------------------
>
> Key: POOL-88
> URL: http://issues.apache.org/jira/browse/POOL-88
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: Nightly Builds
> Reporter: Holger Hoffstätte
> Assigned To: Sandy McArthur
> Priority: Minor
> Fix For: Nightly Builds
>
> Attachments: activeCount.patch
>
>
> GenericKeyedObjectPool maintains a separate map for maintaining active object counts per key. IMHO it is better to put pool metadata together with the pool (queue).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org