You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/16 20:25:54 UTC
[GitHub] [airflow] XD-DENG opened a new pull request #13116: Avoid confusion in doc for CeleryKubernetesExecutor
XD-DENG opened a new pull request #13116:
URL: https://github.com/apache/airflow/pull/13116
The current docstring around CeleryKubernetesExecutor is not clear enough.
- Docstring `When the queue is 'kubernetes', KubernetesExecutor is selected to run the task` is incorrect. The value is configurable, and "kubernetes" is only the default value.
- In the configuration doc, `When the queue of a task is 'kubernetes_queue', ...` is inaccurate. Instead, it should be something like `When the queue of a task is the value of 'kubernetes_queue', ...`.
This PR makes minor changes in the docs to avoid such potential confusions.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #13116: Avoid confusion in doc for CeleryKubernetesExecutor
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #13116:
URL: https://github.com/apache/airflow/pull/13116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13116: Avoid confusion in doc for CeleryKubernetesExecutor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13116:
URL: https://github.com/apache/airflow/pull/13116#issuecomment-747029587
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org