[jira] [Reopened] (CASSANDRA-9749) CommitLogReplayer continues startup after encountering errors

["Joshua McKenzie (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joshua McKenzie reopened CASSANDRA-9749:
----------------------------------------

This commit breaks CommitLogTest on both Windows and Linux.

[Error example|http://cassci.datastax.com/view/cassandra-2.2/job/cassandra-2.2_utest/lastCompletedBuild/testReport/org.apache.cassandra.db.commitlog/CommitLogTest/testRecoveryWithIdMismatch/]

A revert of this commit fixes that. Did we not confirm with CI on this before committing?

> CommitLogReplayer continues startup after encountering errors
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-9749
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9749
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Branimir Lambov
>             Fix For: 2.2.1, 3.0 beta 1
>
>         Attachments: 9749-coverage.tgz
>
>
> There are a few places where the commit log recovery method either skips sections or just returns when it encounters errors.
> Specifically if it can't read the header here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L298
> Or if there are compressor problems here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L314 and here: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L366
> Whether these are user-fixable or not, I think we should require more direct user intervention (ie: fix what's wrong, or remove the bad file and restart) since we're basically losing data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)