You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "renoth (via GitHub)" <gi...@apache.org> on 2023/03/04 13:19:20 UTC
[GitHub] [wicket] renoth opened a new pull request, #555: Add Convenience Methods to BaseWicketTester
renoth opened a new pull request, #555:
URL: https://github.com/apache/wicket/pull/555
- Add getAllComponentsFromLastRenderedPageByWicketId and getFirstComponentFromLastRenderedPageByWicketId to BaseWicketTester
It has always bothered me that unlike TagTester BaseWicketTester has no way of finding Components by Wicket ID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on pull request #555: [WICKET-7030] Add Convenience Methods to BaseWicketTester
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #555:
URL: https://github.com/apache/wicket/pull/555#issuecomment-1469551739
Thank you, @renoth !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] renoth commented on a diff in pull request #555: Add Convenience Methods to BaseWicketTester
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on code in PR #555:
URL: https://github.com/apache/wicket/pull/555#discussion_r1125463714
##########
wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java:
##########
@@ -1576,6 +1577,48 @@ public Component getComponentFromLastRenderedPage(String path)
return getComponentFromLastRenderedPage(path, true);
}
+ /**
+ * TODO
Review Comment:
still todo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] renoth commented on a diff in pull request #555: Add Convenience Methods to BaseWicketTester
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on code in PR #555:
URL: https://github.com/apache/wicket/pull/555#discussion_r1125463763
##########
wicket-spring/src/test/java/org/apache/wicket/spring/injection/bytebuddy/ParallelInjectionTest.java:
##########
@@ -110,7 +110,7 @@ void notParallel() throws Exception {
}
Review Comment:
cleaned up some leftovers that are from my org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on a diff in pull request #555: Add Convenience Methods to BaseWicketTester
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #555:
URL: https://github.com/apache/wicket/pull/555#discussion_r1133148864
##########
wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java:
##########
@@ -1576,6 +1577,48 @@ public Component getComponentFromLastRenderedPage(String path)
return getComponentFromLastRenderedPage(path, true);
}
+ /**
+ * TODO
+ *
+ * @param wicketId
+ * @return
+ */
+ public Optional<Component> getFirstComponentFromLastRenderedPageByWicketId(String wicketId) {
Review Comment:
I think we can remove `FromLastRenderedPage` from the method names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g merged pull request #555: [WICKET-7030] Add Convenience Methods to BaseWicketTester
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #555:
URL: https://github.com/apache/wicket/pull/555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] renoth commented on a diff in pull request #555: [WICKET-7030] Add Convenience Methods to BaseWicketTester
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on code in PR #555:
URL: https://github.com/apache/wicket/pull/555#discussion_r1136240305
##########
wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java:
##########
@@ -1576,6 +1577,48 @@ public Component getComponentFromLastRenderedPage(String path)
return getComponentFromLastRenderedPage(path, true);
}
+ /**
+ * TODO
+ *
+ * @param wicketId
+ * @return
+ */
+ public Optional<Component> getFirstComponentFromLastRenderedPageByWicketId(String wicketId) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org