[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #227: [YUNIKORN-536] Add resource requests and limits for the admission-controller

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #227:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/227#discussion_r569614170



##########
File path: deployments/admission-controllers/scheduler/templates/server.yaml.template
##########
@@ -37,6 +37,13 @@ spec:
           ports:
           - containerPort: 9089
             name: webhook-api
+          resources:
+            limits:
+              cpu: "100m"
+              memory: 500Mi
+            requests:
+              cpu: "500m"
+              memory: 500Mi

Review comment:
       I've done some observations on a live cluster, leveraging kubectl top command, I was able to see the resource utilization of the admission controller pod, it is not using a lot of resources. I tried to create hundreds of pods in a loop to add some loads, it only uses 1~2m CPU, and less than 10m memory, pretty lightweight. So I think this number is sufficient.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org