You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/17 21:04:43 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #5293: DNSSEC Refresh check compile fix

ocket8888 opened a new pull request #5293:
URL: https://github.com/apache/trafficcontrol/pull/5293


   ## What does this PR (Pull Request) do?
   - [x] This PR is not related to any Issue
   
   This PR fixes the [DNSSEC Refresh program](https://github.com/apache/trafficcontrol/tree/master/traffic_ops/app/bin/checks/DnssecRefresh) to compile locally. It was failing to compile because it depends on [`github.com/pborman/getopt/v2`](https://github.com/pborman/getopt/v2) which was outside of its vendor tree.
   
   This PR also adds `go test`-ing checks and changes that check to only `go get` the `golang.org/x/*` dependencies we consider external, so that hopefully vendoring issues can be caught earlier from now on.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops (checks)
   - CI tests
   
   ## What is the best way to verify this PR?
   Hopefully the GHA checks will take care of verification entirely.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests
   - [x] Documentation is unnecessary
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 merged pull request #5293: DNSSEC Refresh check compile fix

Posted by GitBox <gi...@apache.org>.
mitchell852 merged pull request #5293:
URL: https://github.com/apache/trafficcontrol/pull/5293


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org