You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@livy.apache.org by "nileshrathi345 (via GitHub)" <gi...@apache.org> on 2026/10/12 17:22:02 UTC
[PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 [livy]
nileshrathi345 opened a new pull request, #567:
URL: https://github.com/apache/livy/pull/567
## What changes were proposed in this pull request?
This PR upgrades the Livy Thrift Server dependency on org.apache.thrift:libthrift from 0.9.3 to 0.25.0 ([LIVY-1091](https://issues.apache.org/jira/browse/LIVY-1091)).
**Motivation:** Apache Thrift before 0.23.0 is affected by [CVE-2026-43869](https://www.cve.org/CVERecord?id=CVE-2026-43869) (TLS hostname verification in TSSLTransportFactory). Livy’s Thrift Server uses libthrift for binary and HTTP CLI/JDBC transport; bumping to 0.25.0 addresses that class of issues and removes a very old pinned dependency.
Jira: https://issues.apache.org/jira/browse/LIVY-1091
## How was this patch tested?
Compile (Spark 3):
mvn -Pthriftserver -Pspark3 -Pscala-2.12 -pl thriftserver/server,thriftserver/session -am compile -DskipTests
Compile (Spark 4 / default):
mvn -Pthriftserver -pl thriftserver/server,thriftserver/session -am compile -DskipTests
Unit tests:
mvn -Pthriftserver -Pspark3 -Pscala-2.12 -pl thriftserver/session test
(ColumnBufferTest, 6 tests)
## Was this patch authored or co-authored using generative AI tooling?
Co-authored by: Cursor AI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 [livy]
Posted by "roczei (via GitHub)" <gi...@apache.org>.
roczei commented on PR #567:
URL: https://github.com/apache/livy/pull/567#issuecomment-6131208263
Hi @nileshrathi345 ,
Thanks for the PR! Unfortunately there is a CI failure, could you please fix it? Also, please double check locally if all unit and integration tests run without errors for both Spark 4 and Spark 3 using the following commands:
```
mvn -Pthriftserver -Pspark3 -Pscala-2.12 -B verify
mvn -Pthriftserver -B verify
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 [livy]
Posted by "nileshrathi345 (via GitHub)" <gi...@apache.org>.
nileshrathi345 commented on PR #567:
URL: https://github.com/apache/livy/pull/567#issuecomment-6129221925
@gyogal and @roczei
could you please take a look when possible and review
thanks..!!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 and Hive to 4.0.1 for thriftserver [livy]
Posted by "gyogal (via GitHub)" <gi...@apache.org>.
gyogal commented on code in PR #567:
URL: https://github.com/apache/livy/pull/567#discussion_r4394493587
##########
thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala:
##########
@@ -732,4 +786,53 @@ class HttpThriftServerSuite extends ThriftServerBaseTest with CommonThriftTests
getTypeInfoTest(c)
}
}
+
+ test("fetch a large result set over HTTP transport") {
+ // Drives many FetchResults round-trips over HTTP, exercising ThriftHttpServlet
+ // .processThriftRequest and the HttpClient 4.x THttpClient shim end-to-end (not just connect).
+ withJdbcStatement { statement =>
+ val numRows = 10000
+ val rs = statement.executeQuery(s"select id from range($numRows)")
+ var count = 0
+ var sum = 0L
+ while (rs.next()) {
+ sum += rs.getLong(1)
+ count += 1
+ }
+ rs.close()
+ assert(count == numRows)
+ assert(sum == (0L until numRows.toLong).sum)
+ }
+ }
+
+ test("GetInfo returns server/driver metadata") {
+ withJdbcConnection { connection =>
+ val md = connection.getMetaData
+ assert(Option(md.getDatabaseProductName).exists(_.nonEmpty))
+ assert(Option(md.getDatabaseProductVersion).exists(_.nonEmpty))
+ assert(Option(md.getDriverName).exists(_.nonEmpty))
+ }
+ }
+
+ test("cancelling a running query terminates it") {
+ withJdbcStatement { statement =>
+ val error = new AtomicReference[Throwable]()
+ val queryThread = new Thread(new Runnable {
+ override def run(): Unit = {
+ try {
+ statement.executeQuery(
+ "select count(*) from range(1000000) a join range(1000000) b on a.id = b.id")
+ } catch {
+ case t: Throwable => error.set(t)
+ }
+ }
+ })
+ queryThread.start()
+ Thread.sleep(5000)
Review Comment:
This test is duplicated (it is repeated in both `BinaryThriftServerSuite` and `HttpThriftServerSuite`) and I think it may be possible to do this without a `Thread.sleep(5000)`. This is not ideal for two reasons: 1) If the query finished before 5 seconds, the statement cancellation will not be tested 2) These sleeps add 10 seconds to the unit test runs. Would it be possible to check if the query is running first, then cancel it instead of waiting?
##########
thriftserver/server/pom.xml:
##########
@@ -139,7 +139,23 @@
<artifactId>jetty-webapp</artifactId>
Review Comment:
Is jetty-webapp used in this module? If not, is it possible to remove this? It is excluded below, but it is added here as a dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 and Hive to 4.0.1 for thriftserver [livy]
Posted by "nileshrathi345 (via GitHub)" <gi...@apache.org>.
nileshrathi345 commented on code in PR #567:
URL: https://github.com/apache/livy/pull/567#discussion_r4344891583
##########
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/cli/ThriftBinaryCLIService.scala:
##########
@@ -110,11 +110,9 @@ class ThriftBinaryCLIService(override val cliService: LivyCLIService, val oomHoo
new TBinaryProtocol.Factory(true, true, maxMessageSize, maxMessageSize))
.executorService(executorService)
// `requestTimeout`, `requestTimeoutUnit`, `beBackoffSlotLength` and
- // `beBackoffSlotLengthUnit` are present in the libthrift that Livy
- // compiles against (0.9.3, pinned in the root pom) and in the versions
- // Spark 3 brings in transitively, but were removed in libthrift 0.16.0
- // (transitively pulled in by Spark 4). Invoke them reflectively so the
- // same code compiles and runs on both classpaths.
+ // `beBackoffSlotLengthUnit` were removed in libthrift 0.16.0. Invoke them
+ // reflectively so the same binary still runs if an older libthrift is on
+ // the runtime classpath (e.g. Spark 3 transitive versions).
Review Comment:
Added comment on `livy.server.thrift.login.timeout` and `livy.server.thrift.exponential.backoff.slot.length` in `LivyConf.scala` noting they only apply to binary `TThreadPoolServer` and have no effect with libthrift 0.16.0+ (Livy 0.25.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 and Hive to 4.0.1 for thriftserver [livy]
Posted by "nileshrathi345 (via GitHub)" <gi...@apache.org>.
nileshrathi345 commented on code in PR #567:
URL: https://github.com/apache/livy/pull/567#discussion_r4398899534
##########
thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala:
##########
@@ -732,4 +786,53 @@ class HttpThriftServerSuite extends ThriftServerBaseTest with CommonThriftTests
getTypeInfoTest(c)
}
}
+
+ test("fetch a large result set over HTTP transport") {
+ // Drives many FetchResults round-trips over HTTP, exercising ThriftHttpServlet
+ // .processThriftRequest and the HttpClient 4.x THttpClient shim end-to-end (not just connect).
+ withJdbcStatement { statement =>
+ val numRows = 10000
+ val rs = statement.executeQuery(s"select id from range($numRows)")
+ var count = 0
+ var sum = 0L
+ while (rs.next()) {
+ sum += rs.getLong(1)
+ count += 1
+ }
+ rs.close()
+ assert(count == numRows)
+ assert(sum == (0L until numRows.toLong).sum)
+ }
+ }
+
+ test("GetInfo returns server/driver metadata") {
+ withJdbcConnection { connection =>
+ val md = connection.getMetaData
+ assert(Option(md.getDatabaseProductName).exists(_.nonEmpty))
+ assert(Option(md.getDatabaseProductVersion).exists(_.nonEmpty))
+ assert(Option(md.getDriverName).exists(_.nonEmpty))
+ }
+ }
+
+ test("cancelling a running query terminates it") {
+ withJdbcStatement { statement =>
+ val error = new AtomicReference[Throwable]()
+ val queryThread = new Thread(new Runnable {
+ override def run(): Unit = {
+ try {
+ statement.executeQuery(
+ "select count(*) from range(1000000) a join range(1000000) b on a.id = b.id")
+ } catch {
+ case t: Throwable => error.set(t)
+ }
+ }
+ })
+ queryThread.start()
+ Thread.sleep(5000)
Review Comment:
Thanks, good points. If old query finished before the 5s sleep, so the cancel wasn't really being tested.
**Changes:**
- Moved the test into `CommonThriftTests` and call it from both suites. I did the same for the other two duplicated tests (large result set and GetInfo).
- Removed `Thread.sleep`. The test now waits until the server reports the query as RUNNING, then cancels it.
- It now asserts that the operation ends up `CANCELED` and the client gets "Query was cancelled", so a missed cancel fails the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 [livy]
Posted by "nileshrathi345 (via GitHub)" <gi...@apache.org>.
nileshrathi345 commented on PR #567:
URL: https://github.com/apache/livy/pull/567#issuecomment-6140719868
> Hi @nileshrathi345 ,
>
> Thanks for the PR! Unfortunately there is a CI failure, could you please fix it? Also, please double check locally if all unit and integration tests run without errors for both Spark 4 and Spark 3 using the following commands:
>
> ```
> mvn -Pthriftserver -Pspark3 -Pscala-2.12 -B verify
> mvn -Pthriftserver -B verify
> ```
Hi @roczei — thanks for the review.
Why CI failed
After moving to libthrift 0.25, HttpThriftServerSuite failed with:
NoSuchMethodError: THttpClient.<init>(String, org.apache.http.client.HttpClient)
The HTTP thrift integration tests connect with Hive JDBC 3.0, which still builds the HTTP transport using Apache HttpClient 4.x and that constructor.
libthrift 0.25 still has THttpClient, but it only supports HttpClient 5.x — the HttpClient 4 constructor was removed. So the class is present, but the method Hive JDBC calls is not → runtime failure when the suite opens a JDBC connection in HTTP mode.
This is on the test client (JDBC driver) side. The Livy Thrift HTTP server uses our ThriftHttpServlet path, not libthrift’s THttpClient.
Hi @roczei — thanks for the review.
**Why CI failed**
After moving to libthrift 0.25, HttpThriftServerSuite failed with:
NoSuchMethodError: THttpClient.<init>(String, org.apache.http.client.HttpClient)
The HTTP thrift integration tests connect with Hive JDBC 3.0, which still builds the HTTP transport using Apache HttpClient 4.x and that constructor.
libthrift 0.25 still has THttpClient, but it only supports HttpClient 5.x — the HttpClient 4 constructor was removed. So the class is present, but the method Hive JDBC calls is not → runtime failure when the suite opens a JDBC connection in HTTP mode.
This is on the test client (JDBC driver) side. The Livy Thrift HTTP server uses our ThriftHttpServlet path, not libthrift’s THttpClient.
**Fix:**
Added a test-only org.apache.thrift.transport.THttpClient under thriftserver/server/src/test/java that restores the HttpClient 4.x constructor for the JDBC client during ITs. It is not part of the shipped server artifact.
**Local verification**
Both commands completed successfully on my side:
mvn -Pthriftserver -Pspark3 -Pscala-2.12 -B verify
mvn -Pthriftserver -B verify
nilesh.rathi@HQV9WP4F7Y livy % mvn -Pthriftserver -B verify
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 1 licenses.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Livy Project Parent POM 1.0.0-SNAPSHOT:
[INFO]
[INFO] Livy Project Parent POM ............................ SUCCESS [ 3.865 s]
[INFO] livy-api ........................................... SUCCESS [ 7.253 s]
[INFO] livy-client-common ................................. SUCCESS [ 2.935 s]
[INFO] livy-test-lib ...................................... SUCCESS [ 3.826 s]
[INFO] multi-scala-project-root ........................... SUCCESS [ 0.992 s]
[INFO] livy-core-parent ................................... SUCCESS [ 0.309 s]
[INFO] livy-core_2.13 ..................................... SUCCESS [ 1.688 s]
[INFO] livy-rsc ........................................... SUCCESS [ 31.163 s]
[INFO] livy-repl-parent ................................... SUCCESS [ 3.981 s]
[INFO] livy-repl_2.13 ..................................... SUCCESS [01:36 min]
[INFO] livy-server ........................................ SUCCESS [03:42 min]
[INFO] livy-thriftserver-session .......................... SUCCESS [ 13.825 s]
[INFO] livy-thriftserver .................................. SUCCESS [05:44 min]
[INFO] livy-assembly ...................................... SUCCESS [ 5.076 s]
[INFO] livy-client-http ................................... SUCCESS [ 13.519 s]
[INFO] livy-scala-api-parent .............................. SUCCESS [ 1.303 s]
[INFO] livy-scala-api_2.13 ................................ SUCCESS [ 21.939 s]
[INFO] livy-integration-test .............................. SUCCESS [25:58 min]
[INFO] livy-coverage-report ............................... SUCCESS [ 3.833 s]
[INFO] livy-examples ...................................... SUCCESS [ 4.560 s]
[INFO] livy-python-api .................................... SUCCESS [ 2.868 s]
[INFO] livy-beeline ....................................... SUCCESS [ 3.500 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39:09 min
[INFO] Finished at: 2026-10-13T12:25:15+05:30
[INFO] ------------------------------------------------------------------------
nilesh.rathi@HQV9WP4F7Y livy %
nilesh.rathi@HQV9WP4F7Y livy % mvn -Pthriftserver -Pspark3 -Pscala-2.12 -B verify
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 1 licenses.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Livy Project Parent POM 1.0.0-SNAPSHOT:
[INFO]
[INFO] Livy Project Parent POM ............................ SUCCESS [ 3.367 s]
[INFO] livy-api ........................................... SUCCESS [ 5.516 s]
[INFO] livy-client-common ................................. SUCCESS [ 3.226 s]
[INFO] livy-test-lib ...................................... SUCCESS [ 3.005 s]
[INFO] multi-scala-project-root ........................... SUCCESS [ 0.946 s]
[INFO] livy-core-parent ................................... SUCCESS [ 0.353 s]
[INFO] livy-core_2.12 ..................................... SUCCESS [ 1.505 s]
[INFO] livy-rsc ........................................... SUCCESS [ 26.984 s]
[INFO] livy-repl-parent ................................... SUCCESS [ 2.992 s]
[INFO] livy-repl_2.12 ..................................... SUCCESS [01:51 min]
[INFO] livy-server ........................................ SUCCESS [03:33 min]
[INFO] livy-thriftserver-session .......................... SUCCESS [ 12.268 s]
[INFO] livy-thriftserver .................................. SUCCESS [06:01 min]
[INFO] livy-assembly ...................................... SUCCESS [ 3.838 s]
[INFO] livy-client-http ................................... SUCCESS [ 12.382 s]
[INFO] livy-scala-api-parent .............................. SUCCESS [ 0.662 s]
[INFO] livy-scala-api_2.12 ................................ SUCCESS [ 21.920 s]
[INFO] livy-integration-test .............................. SUCCESS [19:46 min]
[INFO] livy-coverage-report ............................... SUCCESS [ 3.499 s]
[INFO] livy-examples ...................................... SUCCESS [ 4.140 s]
[INFO] livy-python-api .................................... SUCCESS [ 2.674 s]
[INFO] livy-beeline ....................................... SUCCESS [ 3.465 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33:05 min
[INFO] Finished at: 2026-10-13T11:43:35+05:30
[INFO] ------------------------------------------------------------------------
nilesh.rathi@HQV9WP4F7Y livy %
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 and Hive to 4.0.1 for thriftserver [livy]
Posted by "nileshrathi345 (via GitHub)" <gi...@apache.org>.
nileshrathi345 commented on code in PR #567:
URL: https://github.com/apache/livy/pull/567#discussion_r4398863609
##########
thriftserver/server/pom.xml:
##########
@@ -139,7 +139,23 @@
<artifactId>jetty-webapp</artifactId>
Review Comment:
Checked: nothing in the module uses jetty-webapp. It was carried over from the jetty-runner replacement in [#566](https://github.com/apache/livy/pull/566).
` jetty-webapp` is not used by this module, so I've removed the dependency. Only `jetty-server` and `jetty-servlet` are used directly (ThriftHttpCLIService). jetty-util comes in transitively through jetty-server, and all Jetty versions are managed in the root pom.
I also removed the `excludeArtifactIds` block `(jetty-util, jetty-xml, jetty-webapp)` from copy-dependencies. It had been re-introduced by mistake from an older base of the branch. I checked the dependency tree under both the default and `-Pspark3 -Pscala-2.12` profiles: `jetty-webapp` and `jetty-xml` now only appear at test/provided scope via hive-common, and nothing in the runtime jars references them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 [livy]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #567:
URL: https://github.com/apache/livy/pull/567#issuecomment-6148097384
## [Codecov](https://app.codecov.io/gh/apache/livy/pull/567?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 69.13%. Comparing base ([`fc5f238`](https://app.codecov.io/gh/apache/livy/commit/fc5f2387be5682f880503ad98b4fcec3bfa190aa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1fd8412`](https://app.codecov.io/gh/apache/livy/commit/1fd8412235b6a592ebb4aa0e2c12c12b38775b9e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #567 +/- ##
============================================
+ Coverage 69.03% 69.13% +0.09%
- Complexity 1231 1232 +1
============================================
Files 107 107
Lines 6986 6979 -7
Branches 858 857 -1
============================================
+ Hits 4823 4825 +2
+ Misses 1689 1682 -7
+ Partials 474 472 -2
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/livy/pull/567?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 and [LIVY-1093] Upgrade Hive to 4.0.1 for thriftserver [livy]
Posted by "gyogal (via GitHub)" <gi...@apache.org>.
gyogal commented on code in PR #567:
URL: https://github.com/apache/livy/pull/567#discussion_r4341414605
##########
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/cli/ThriftBinaryCLIService.scala:
##########
@@ -110,11 +110,9 @@ class ThriftBinaryCLIService(override val cliService: LivyCLIService, val oomHoo
new TBinaryProtocol.Factory(true, true, maxMessageSize, maxMessageSize))
.executorService(executorService)
// `requestTimeout`, `requestTimeoutUnit`, `beBackoffSlotLength` and
- // `beBackoffSlotLengthUnit` are present in the libthrift that Livy
- // compiles against (0.9.3, pinned in the root pom) and in the versions
- // Spark 3 brings in transitively, but were removed in libthrift 0.16.0
- // (transitively pulled in by Spark 4). Invoke them reflectively so the
- // same code compiles and runs on both classpaths.
+ // `beBackoffSlotLengthUnit` were removed in libthrift 0.16.0. Invoke them
+ // reflectively so the same binary still runs if an older libthrift is on
+ // the runtime classpath (e.g. Spark 3 transitive versions).
Review Comment:
It could be worth adding a comment to `livy.server.thrift.login.timeout` / `livy.server.thrift.exponential.backoff.slot.length` in `LivyConf.scala` that these two settings have no effect with libthrift 0.16.0+ so that anybody who wants to configure them are aware of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Livy-1091] Upgrade libthrift 0.9.3 to 0.25.0 and [LIVY-1093] Upgrade Hive to 4.0.1 for thriftserver [livy]
Posted by "gyogal (via GitHub)" <gi...@apache.org>.
gyogal commented on PR #567:
URL: https://github.com/apache/livy/pull/567#issuecomment-6325871975
Thanks for your PR @nileshrathi345! Could you please use a single JIRA and use that as the PR title? The commits will be squashed during the merge and they should be in the usual format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org