You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by liuyu000 <gi...@git.apache.org> on 2018/07/13 06:07:05 UTC
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Add examples (NCHAR) of *CREA...
GitHub user liuyu000 opened a pull request:
https://github.com/apache/trafodion/pull/1644
[TRAFODION-3142] Add examples (NCHAR) of *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liuyu000/trafodion CreateTableStatement_nchar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1644.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1644
----
commit 1fd84078baf3990fae392f55bf01f0c6d0fc6e37
Author: liu.yu <qw...@...>
Date: 2018-07-13T06:05:40Z
[TRAFODION-3142] Add examples (NCHAR) of *CREATE TABLE Statement* in *Trafodion SQL Reference Manual*
----
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r202873460
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [length [characters]]
--- End diff --
Thanks for your review @DaveBirdsall
`length [characters]` is optional.
If `length` is not specified, the default is 1.
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r202728022
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [length [characters]]
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
| char[acter] varying (length [characters])
- [character set char-set-name]
- [upshift] [[not]casespecific]
- | varchar (length) [character set char-set-name]
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | varchar (length [characters])
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | varchar2 (length [characters])
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | nchar [length [characters]]
--- End diff --
Should be "nchar (length [characters])"
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r203093950
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [length [characters]]
--- End diff --
FYI: I double-checked the parser code. Length is optional for CHAR and NCHAR. Length is required for VARCHAR and NCHAR VARYING.
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r202880294
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -3712,6 +3716,60 @@ ATTRIBUTES ALIGNED FORMAT
--- SQL operation complete.
```
+* This example demonstrates the character set of NCHAR column (_c1_) *cannot be specified*.
--- End diff --
Thanks Dave, your comments have been incorporated 😁
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1644
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r203581595
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [(length) [characters]]
--- End diff --
Thanks for your eagle eye 😁
Sorry it's my careless mistake :pig: I've corrected them all :pencil2:
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r203584509
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [(length) [characters]]
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
| char[acter] varying (length [characters])
- [character set char-set-name]
- [upshift] [[not]casespecific]
- | varchar (length) [character set char-set-name]
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | varchar (length [characters])
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | varchar2 (length [characters])
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | nchar [(length) [characters]]
--- End diff --
Thanks, I've corrected :rowboat:
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r203233947
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [length [characters]]
--- End diff --
Yes, the origin text is right, I've corrected my writing 😁
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r203091243
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [length [characters]]
--- End diff --
Ah, good catch! I stand corrected. So, the original text, "char[acter] [(length [characters])] was correct? (The parentheses are needed if a length is supplied.)
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r202873886
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [length [characters]]
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
| char[acter] varying (length [characters])
- [character set char-set-name]
- [upshift] [[not]casespecific]
- | varchar (length) [character set char-set-name]
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | varchar (length [characters])
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | varchar2 (length [characters])
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | nchar [length [characters]]
--- End diff --
Same as above.
`length [characters]` is optional.
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r203554845
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [(length) [characters]]
--- End diff --
Should be "char[acter] [(length [characters])]" (The trailing parenthesis should come after the optional [characters] syntactic element)
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r203554900
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [(length) [characters]]
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
| char[acter] varying (length [characters])
- [character set char-set-name]
- [upshift] [[not]casespecific]
- | varchar (length) [character set char-set-name]
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | varchar (length [characters])
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | varchar2 (length [characters])
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | nchar [(length) [characters]]
--- End diff --
Same comment here.
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r202727823
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [length [characters]]
--- End diff --
I think you meant, "char[acter] (length [characters])" (That is, the length is surrounded by parentheses, and it is not optional.)
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r202731971
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -3712,6 +3716,60 @@ ATTRIBUTES ALIGNED FORMAT
--- SQL operation complete.
```
+* This example demonstrates the character set of NCHAR column (_c1_) *cannot be specified*.
--- End diff --
I think one example is probably enough. The point we are trying to make is that "NATIONAL CHAR" implies a particular character set, namely, "UCS2". This is hard-coded into the product; it cannot be changed. Possible word-smith: "NATIONAL CHAR (or NCHAR) is a short-hand for CHAR ... CHARACTER SET UCS2. So it is not possible to specify a CHARACTER SET clause when using NCHAR, as the following example shows:"
---
[GitHub] trafodion pull request #1644: [TRAFODION-3142] Correct Syntactic Description...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1644#discussion_r203234030
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -2963,18 +2963,22 @@ column-definition is:
<<<
```
data-type is:
- char[acter] [(length [characters])]
- [character set char-set-name]
- [upshift] [[not]casespecific]
+ char[acter] [length [characters]]
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
| char[acter] varying (length [characters])
- [character set char-set-name]
- [upshift] [[not]casespecific]
- | varchar (length) [character set char-set-name]
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | varchar (length [characters])
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | varchar2 (length [characters])
+ [character set char-set-name]
+ [upshift] [[not]casespecific]
+ | nchar [length [characters]]
--- End diff --
Here should be `nchar [(length) [characters]]` 😁
---