You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2016/06/17 00:11:23 UTC

[GitHub] incubator-quickstep pull request #35: QUICKSTEP-20: Added Parser support for...

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/35#discussion_r67445231
  
    --- Diff: parser/CMakeLists.txt ---
    @@ -114,6 +114,7 @@ add_library(quickstep_parser_ParseSubqueryTableReference ParseSubqueryTableRefer
     add_library(quickstep_parser_ParseTableReference ParseTableReference.cpp ParseTableReference.hpp)
     add_library(quickstep_parser_ParseTreeNode ../empty_src.cpp ParseTreeNode.hpp)
     add_library(quickstep_parser_ParserUtil ParserUtil.cpp ParserUtil.hpp)
    +add_library(quickstep_parser_ParseWindow ../empty_src.cpp ParseWindow.hpp)
    --- End diff --
    
    Please sort in the alphabet order, i.e., putting between `quickstep_parser_ParseTreeNode` and `quickstep_parser_ParserUtil`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---