[jira] [Commented] (PHOENIX-3981) Ensure iterators are closed for join plans

["Thomas D'Silva (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067032#comment-16067032 ] 

Thomas D'Silva commented on PHOENIX-3981:
-----------------------------------------

Do we need the changed to HashJoinPlan? The ServerCache returned by SubPlan.execute()  is added to HashJoinPlan.dependencies

and this ends up calling BaseQueryPlan.iterator

{code}
ResultIterator iterator = joinInfo == null ? delegate.iterator(scanGrouper, scan) : ((BaseQueryPlan) delegate).iterator(dependencies, scanGrouper, scan);
{code}

which will then close the dependencies.

The other change looks good.

> Ensure iterators are closed for join plans
> ------------------------------------------
>
>                 Key: PHOENIX-3981
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3981
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-3981.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)