[GitHub] [iceberg] jackye1995 commented on a change in pull request #1844: AWS: support custom client configuration

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #1844:
URL: https://github.com/apache/iceberg/pull/1844#discussion_r534575698



##########
File path: core/src/main/java/org/apache/iceberg/util/PropertyUtil.java
##########
@@ -44,6 +44,11 @@ public static double propertyAsDouble(Map<String, String> properties,
     return defaultValue;
   }
 
+  public static Integer propertyAsInt(Map<String, String> properties, String property) {
+    String value = properties.get(property);

Review comment:
       All methods in this util assumes properties is not null.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org