You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/12 22:00:05 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28319: Selective checks for API did not match API test specification
potiuk opened a new pull request, #28319:
URL: https://github.com/apache/airflow/pull/28319
The selective checks for the API had "^tests/api" as matching regexp, where we used "tests/api_connexion" to trigger the tests. This means that changes to "tests/api_internal" were not treated as "Other", because they were included in the API regexp.
This PR fixes it.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28319: Selective checks for API did not match API test specification
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28319:
URL: https://github.com/apache/airflow/pull/28319#issuecomment-1347972288
Yeah that might be some kind of misunderstanding with test categorisation.
I assume initially that it should be a part of `API` tests but also it might be a part of `Core`.
And one question about `Other` right now in this category also added System (AIP-47) Tests, might be better move it out into the separate category?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28319: Selective checks for API did not match API test specification
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28319:
URL: https://github.com/apache/airflow/pull/28319#issuecomment-1348963194
> And one question about Other right now in this category also added System (AIP-47) Tests, might be better move it out into the separate category?
System tests are specifically excluded - this is entire different "category" of tests and they are not automatically run in CI.
They should not show up in "Other" - but maybe they do actually in "selective checks" :). Maybe we should remove them though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28319: Selective checks for API did not match API test specification
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28319:
URL: https://github.com/apache/airflow/pull/28319#issuecomment-1349024266
We can exclude them from Other category when running tests actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28319: Selective checks for API did not match API test specification
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28319:
URL: https://github.com/apache/airflow/pull/28319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28319: Selective checks for API did not match API test specification
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28319:
URL: https://github.com/apache/airflow/pull/28319#issuecomment-1347457987
> Looks like the actual command is constructed in another place: https://github.com/apache/airflow/actions/runs/3680179020/jobs/6225576889#step:6:1901
>
> ```
> Running tests tests/api tests/api_connexion
>
>
> Starting the tests with those pytest arguments: --verbosity=0 --strict-markers --durations=100 --maxfail=50 --color=yes --junitxml=/files/test_result-API-sqlite.xml --timeouts-order moi --setup-timeout=60 --execution-timeout=60 --teardown-timeout=60 --output=/files/warnings-API-sqlite.txt --disable-warnings -rfEX --with-db-init tests/api tests/api_connexion
> ```
Yep. This is exactly what we are synchronizing with. The test command specifically calls out the directories to use and the regexp in selective checks is used to determine if it should be run or not.
So what the change brings is syncing these two:
1) selective tests determines which file changes should trigger the tests
2) the command you pointed out executes those
The problem was that the regexp also matched `test_api_internal` because this is how regexp works when there is no '/'. This PR changes the regexp to take into account the fact that there might be other directores starting with `tests_api` - they were previously matched by regexp but not executed by the "API" test type (when you run `pytest tests_api tests_connexion` the `tests_api_internal` are not run.
When this PR is merged, if there is a change coming in `tests_api_internal`, it is treated as `other` which triggers "all" test. Which is what we want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28319: Selective checks for API did not match API test specification
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28319:
URL: https://github.com/apache/airflow/pull/28319#issuecomment-1349010577
If we exclude `tests/system` of any category than we do not check is it parsable by `pytest` or not.
But command in `Other` really big right now:
```console
Running tests tests/triggers tests/timetables tests/testconfig tests/testconfig/conf tests/test_utils tests/test_utils/perf
tests/test_utils/perf/perf_kit tests/test_utils/perf/dags tests/test_utils/operators tests/task tests/task/task_runner
tests/system tests/system/utils tests/system/providers tests/system/providers/zendesk tests/system/providers/yandex
tests/system/providers/trino tests/system/providers/telegram tests/system/providers/tabular
tests/system/providers/tableau tests/system/providers/sqlite tests/system/providers/snowflake
tests/system/providers/slack tests/system/providers/singularity tests/system/providers/salesforce
tests/system/providers/qubole tests/system/providers/presto tests/system/providers/postgres
tests/system/providers/plexus tests/system/providers/papermill tests/system/providers/opsgenie
tests/system/providers/neo4j tests/system/providers/mysql tests/system/providers/microsoft
tests/system/providers/microsoft/winrm tests/system/providers/microsoft/mssql tests/system/providers/microsoft/azure
tests/system/providers/jenkins tests/system/providers/jdbc tests/system/providers/influxdb tests/system/providers/http
tests/system/providers/google tests/system/providers/google/workplace tests/system/providers/google/suite
tests/system/providers/google/suite/resources tests/system/providers/google/marketing_platform
tests/system/providers/google/leveldb tests/system/providers/google/firebase tests/system/providers/google/datacatalog
tests/system/providers/google/cloud tests/system/providers/google/cloud/workflows
tests/system/providers/google/cloud/vision tests/system/providers/google/cloud/video_intelligence
tests/system/providers/google/cloud/vertex_ai tests/system/providers/google/cloud/vertex_ai/resources
tests/system/providers/google/cloud/translate_speech tests/system/providers/google/cloud/translate
tests/system/providers/google/cloud/transfers tests/system/providers/google/cloud/transfers/resources
tests/system/providers/google/cloud/text_to_speech tests/system/providers/google/cloud/tasks
tests/system/providers/google/cloud/storage_transfer tests/system/providers/google/cloud/storage_transfer/resources
tests/system/providers/google/cloud/stackdriver tests/system/providers/google/cloud/sql_to_sheets
tests/system/providers/google/cloud/speech_to_text tests/system/providers/google/cloud/spanner
tests/system/providers/google/cloud/pubsub tests/system/providers/google/cloud/natural_language
tests/system/providers/google/cloud/ml_engine tests/system/providers/google/cloud/life_sciences
tests/system/providers/google/cloud/life_sciences/resources tests/system/providers/google/cloud/kubernetes_engine
tests/system/providers/google/cloud/gcs tests/system/providers/google/cloud/gcs/resources
tests/system/providers/google/cloud/datastore tests/system/providers/google/cloud/dataproc_metastore
tests/system/providers/google/cloud/dataproc tests/system/providers/google/cloud/dataproc/resources
tests/system/providers/google/cloud/dataprep tests/system/providers/google/cloud/dataplex
tests/system/providers/google/cloud/dataplex/resources tests/system/providers/google/cloud/dataform
tests/system/providers/google/cloud/dataflow tests/system/providers/google/cloud/dataflow/resources
tests/system/providers/google/cloud/data_loss_prevention
tests/system/providers/google/cloud/data_loss_prevention/resources tests/system/providers/google/cloud/compute
tests/system/providers/google/cloud/composer tests/system/providers/google/cloud/cloud_sql
tests/system/providers/google/cloud/cloud_memorystore tests/system/providers/google/cloud/cloud_functions
tests/system/providers/google/cloud/cloud_build tests/system/providers/google/cloud/cloud_build/resources
tests/system/providers/google/cloud/bigtable tests/system/providers/google/cloud/bigquery
tests/system/providers/google/cloud/bigquery/resources tests/system/providers/google/cloud/azure
tests/system/providers/google/cloud/automl tests/system/providers/google/ads tests/system/providers/github
tests/system/providers/ftp tests/system/providers/elasticsearch tests/system/providers/docker
tests/system/providers/dingding tests/system/providers/dbt tests/system/providers/dbt/cloud
tests/system/providers/databricks tests/system/providers/common tests/system/providers/common/sql
tests/system/providers/cncf tests/system/providers/cncf/kubernetes tests/system/providers/asana
tests/system/providers/apache tests/system/providers/apache/spark tests/system/providers/apache/pig
tests/system/providers/apache/livy tests/system/providers/apache/kylin tests/system/providers/apache/hive
tests/system/providers/apache/druid tests/system/providers/apache/drill tests/system/providers/apache/cassandra
tests/system/providers/apache/beam tests/system/providers/amazon tests/system/providers/amazon/aws
tests/system/providers/amazon/aws/utils tests/system/providers/alibaba tests/system/providers/airbyte tests/sensors
tests/security tests/secrets tests/plugins tests/operators tests/macros tests/listeners tests/lineage tests/kubernetes
tests/kubernetes/models tests/internal_api tests/hooks tests/decorators tests/datasets tests/dag_processing
tests/config_templates tests/cluster_policies tests/callbacks
Starting the tests with those pytest arguments: --verbosity=0 --strict-markers --durations=100 --maxfail=50 --color=yes --junitxml=/files/test_result-Other-sqlite.xml --timeouts-order moi --setup-timeout=60 --execution-timeout=60 --teardown-timeout=60 --output=/files/warnings-Other-sqlite.txt --disable-warnings -rfEX --with-db-init tests/triggers tests/timetables tests/testconfig tests/testconfig/conf tests/test_utils tests/test_utils/perf tests/test_utils/perf/perf_kit tests/test_utils/perf/dags tests/test_utils/operators tests/task tests/task/task_runner tests/system tests/system/utils tests/system/providers tests/system/providers/zendesk tests/system/providers/yandex tests/system/providers/trino tests/system/providers/telegram tests/system/providers/tabular tests/system/providers/tableau tests/system/providers/sqlite tests/system/providers/snowflake tests/system/providers/slack tests/system/providers/singularity tests/system/providers/salesforce tests/system/providers/qubole
tests/system/providers/presto tests/system/providers/postgres tests/system/providers/plexus tests/system/providers/papermill tests/system/providers/opsgenie tests/system/providers/neo4j tests/system/providers/mysql tests/system/providers/microsoft tests/system/providers/microsoft/winrm tests/system/providers/microsoft/mssql tests/system/providers/microsoft/azure tests/system/providers/jenkins tests/system/providers/jdbc tests/system/providers/influxdb tests/system/providers/http tests/system/providers/google tests/system/providers/google/workplace tests/system/providers/google/suite tests/system/providers/google/suite/resources tests/system/providers/google/marketing_platform tests/system/providers/google/leveldb tests/system/providers/google/firebase tests/system/providers/google/datacatalog tests/system/providers/google/cloud tests/system/providers/google/cloud/workflows tests/system/providers/google/cloud/vision tests/system/providers/google/cloud/video_intelligence tests/system/
providers/google/cloud/vertex_ai tests/system/providers/google/cloud/vertex_ai/resources tests/system/providers/google/cloud/translate_speech tests/system/providers/google/cloud/translate tests/system/providers/google/cloud/transfers tests/system/providers/google/cloud/transfers/resources tests/system/providers/google/cloud/text_to_speech tests/system/providers/google/cloud/tasks tests/system/providers/google/cloud/storage_transfer tests/system/providers/google/cloud/storage_transfer/resources tests/system/providers/google/cloud/stackdriver tests/system/providers/google/cloud/sql_to_sheets tests/system/providers/google/cloud/speech_to_text tests/system/providers/google/cloud/spanner tests/system/providers/google/cloud/pubsub tests/system/providers/google/cloud/natural_language tests/system/providers/google/cloud/ml_engine tests/system/providers/google/cloud/life_sciences tests/system/providers/google/cloud/life_sciences/resources tests/system/providers/google/cloud/kubernetes_engine
tests/system/providers/google/cloud/gcs tests/system/providers/google/cloud/gcs/resources tests/system/providers/google/cloud/datastore tests/system/providers/google/cloud/dataproc_metastore tests/system/providers/google/cloud/dataproc tests/system/providers/google/cloud/dataproc/resources tests/system/providers/google/cloud/dataprep tests/system/providers/google/cloud/dataplex tests/system/providers/google/cloud/dataplex/resources tests/system/providers/google/cloud/dataform tests/system/providers/google/cloud/dataflow tests/system/providers/google/cloud/dataflow/resources tests/system/providers/google/cloud/data_loss_prevention tests/system/providers/google/cloud/data_loss_prevention/resources tests/system/providers/google/cloud/compute tests/system/providers/google/cloud/composer tests/system/providers/google/cloud/cloud_sql tests/system/providers/google/cloud/cloud_memorystore tests/system/providers/google/cloud/cloud_functions tests/system/providers/google/cloud/cloud_build te
sts/system/providers/google/cloud/cloud_build/resources tests/system/providers/google/cloud/bigtable tests/system/providers/google/cloud/bigquery tests/system/providers/google/cloud/bigquery/resources tests/system/providers/google/cloud/azure tests/system/providers/google/cloud/automl tests/system/providers/google/ads tests/system/providers/github tests/system/providers/ftp tests/system/providers/elasticsearch tests/system/providers/docker tests/system/providers/dingding tests/system/providers/dbt tests/system/providers/dbt/cloud tests/system/providers/databricks tests/system/providers/common tests/system/providers/common/sql tests/system/providers/cncf tests/system/providers/cncf/kubernetes tests/system/providers/asana tests/system/providers/apache tests/system/providers/apache/spark tests/system/providers/apache/pig tests/system/providers/apache/livy tests/system/providers/apache/kylin tests/system/providers/apache/hive tests/system/providers/apache/druid tests/system/providers/ap
ache/drill tests/system/providers/apache/cassandra tests/system/providers/apache/beam tests/system/providers/amazon tests/system/providers/amazon/aws tests/system/providers/amazon/aws/utils tests/system/providers/alibaba tests/system/providers/airbyte tests/sensors tests/security tests/secrets tests/plugins tests/operators tests/macros tests/listeners tests/lineage tests/kubernetes tests/kubernetes/models tests/internal_api tests/hooks tests/decorators tests/datasets tests/dag_processing tests/config_templates tests/cluster_policies tests/callbacks
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28319: Selective checks for API did not match API test specification
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28319:
URL: https://github.com/apache/airflow/pull/28319#issuecomment-1347435350
Looks like the actual command is constructed in another place: https://github.com/apache/airflow/actions/runs/3680179020/jobs/6225576889#step:6:1901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org