You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/17 04:09:23 UTC
[GitHub] [skywalking] wu-sheng opened a new issue, #9794: [Known Bug] [Archived] getEndpointInfo doesn't verify endpoint ID
wu-sheng opened a new issue, #9794:
URL: https://github.com/apache/skywalking/issues/9794
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
OAP server (apache/skywalking)
### What happened
This is a known bug and is implemented intentionally. The size of the endpoint dataset is enormous, 1m+ candidate is possible. So, we just use an in-memory decode, rather than a query to the database. Also, due to the same encoding rules of endpoint ID and instance ID, an instance ID and any ID following the endpoint encoding format could be accepted by the method, and respond successfully.
### What you expected to happen
`getEndpointInfo(endpointId: ID!): EndpointInfo` in medata-query v2(GraphQL) is only decoding the name of service and endpoint from a given ID, but never verified with the database whether this is a real endpoint.
### How to reproduce
You could use an instance ID to get instance name and service name from this method successfully.
### Anything else
We are not fixing this bug, for now, as basically this is acceptable and should not have serious side effects.
If anyone has a use case to show a serious issue, please reply here.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #9794: [Known Bug] [Archived] getEndpointInfo doesn't verify endpoint ID
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9794: [Known Bug] [Archived] getEndpointInfo doesn't verify endpoint ID
URL: https://github.com/apache/skywalking/issues/9794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org