You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Martin Traverso (JIRA)" <ji...@apache.org> on 2008/02/26 04:41:51 UTC

[jira] Created: (HADOOP-2895) String for configuring profiling should be customizable

String for configuring profiling should be customizable
-------------------------------------------------------

                 Key: HADOOP-2895
                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
             Project: Hadoop Core
          Issue Type: Improvement
          Components: mapred
    Affects Versions: 0.16.0
            Reporter: Martin Traverso


The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Martin Traverso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Traverso updated HADOOP-2895:
------------------------------------

    Attachment: HADOOP-2895.patch

This patch adds a new property (mapred.task.profile.params) to configure the parameters that get passed to the child vm for when profiling is enabled.

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>         Attachments: HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573549#action_12573549 ] 

Hadoop QA commented on HADOOP-2895:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12376769/HADOOP-2895-2.patch
against trunk revision 619744.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests -1.  The patch failed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1868/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1868/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1868/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1868/console

This message is automatically generated.

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>         Attachments: HADOOP-2895-2.patch, HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574101#action_12574101 ] 

Hudson commented on HADOOP-2895:
--------------------------------

Integrated in Hadoop-trunk #416 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/416/])

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-2895-2.patch, HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573464#action_12573464 ] 

Chris Douglas commented on HADOOP-2895:
---------------------------------------

The patch looks good. A minor nit: reordering/sorting the import stmts to match your preferences- and formatting changes in general- adds unnecessary noise and is best avoided unless the changes to the affected classes are dramatic. Would you mind regenerating your patch without those modifications? Otherwise, +1

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>         Attachments: HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573165#action_12573165 ] 

Hadoop QA commented on HADOOP-2895:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12376662/HADOOP-2895.patch
against trunk revision 619744.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1858/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1858/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1858/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1858/console

This message is automatically generated.

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>         Attachments: HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Martin Traverso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Traverso updated HADOOP-2895:
------------------------------------

    Attachment: HADOOP-2895-2.patch

Agreed. That was unintentional -- apparently I had IDEA configured to optimize imports when generating patches.

Here's a new patch with only the necessary changes.

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>         Attachments: HADOOP-2895-2.patch, HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-2895:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.17.0
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Martin!

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-2895-2.patch, HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Martin Traverso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Traverso reassigned HADOOP-2895:
---------------------------------------

    Assignee: Martin Traverso

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Martin Traverso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Traverso updated HADOOP-2895:
------------------------------------

    Status: Patch Available  (was: Open)

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>         Attachments: HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Martin Traverso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Traverso updated HADOOP-2895:
------------------------------------

    Status: In Progress  (was: Patch Available)

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>         Attachments: HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2895) String for configuring profiling should be customizable

Posted by "Martin Traverso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Traverso updated HADOOP-2895:
------------------------------------

    Status: Patch Available  (was: In Progress)

> String for configuring profiling should be customizable
> -------------------------------------------------------
>
>                 Key: HADOOP-2895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2895
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.16.0
>            Reporter: Martin Traverso
>            Assignee: Martin Traverso
>         Attachments: HADOOP-2895-2.patch, HADOOP-2895.patch
>
>
> The choice of options that Hadoop uses may not be appropriate for all cases, so it would make sense to make this string configurable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.