You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by vladimirtkach <gi...@git.apache.org> on 2018/03/07 08:48:54 UTC
[GitHub] drill pull request #1154: NaN/Inf: NestedLoopJoin processes NaN values incor...
GitHub user vladimirtkach opened a pull request:
https://github.com/apache/drill/pull/1154
NaN/Inf: NestedLoopJoin processes NaN values incorrectly
- Changed loggic for equality functions to handle NaN values as the biggest ones
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimirtkach/drill DRILL-6217
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1154
----
commit 345f48dc87bad0434b75914037aa9407538140ec
Author: Vladimir Tkach <vo...@...>
Date: 2018-03-06T09:42:02Z
NaN/Inf: NestedLoopJoin processes NaN values incorrectly
- Changed loggic for equality functions to handle NaN values as the biggest ones
----
---
[GitHub] drill issue #1154: NaN/Inf: NestedLoopJoin processes NaN values incorrectly
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1154
Please add unit tests for each join type (good example - TestJoinEmptyDirTable.java)
---
[GitHub] drill issue #1154: DRILL-6217: NaN/Inf NestedLoopJoin processes NaN values i...
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1154
+1, thanks for making the changes.
---
[GitHub] drill issue #1154: NaN/Inf: NestedLoopJoin processes NaN values incorrectly
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1154
@vladimirtkach Use JIRA in PR title (to automatically update JIRA with a link to the PR and PR updates).
---
[GitHub] drill pull request #1154: DRILL-6217: NaN/Inf NestedLoopJoin processes NaN v...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1154
---
[GitHub] drill pull request #1154: DRILL-6217: NaN/Inf NestedLoopJoin processes NaN v...
Posted by vladimirtkach <gi...@git.apache.org>.
Github user vladimirtkach commented on a diff in the pull request:
https://github.com/apache/drill/pull/1154#discussion_r173437623
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNanInf.java ---
@@ -331,4 +343,63 @@ public void testInnerJoinWithNaN() throws Exception {
}
}
+ @Test
+ public void testHashJoinWithNaN() throws Exception {
--- End diff --
@arina-ielchiieva added resetting of default options
---
[GitHub] drill pull request #1154: DRILL-6217: NaN/Inf NestedLoopJoin processes NaN v...
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1154#discussion_r173426691
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNanInf.java ---
@@ -331,4 +343,63 @@ public void testInnerJoinWithNaN() throws Exception {
}
}
+ @Test
+ public void testHashJoinWithNaN() throws Exception {
--- End diff --
When do you reset join options (`JoinTestBase.resetJoinOptions()`)?
---