[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #487: nimble/ll: Update DID when enabling or disabling periodic advertising

[GitBox <gi...@apache.org>]

sjanc commented on a change in pull request #487: nimble/ll: Update DID when enabling or disabling periodic advertising
URL: https://github.com/apache/mynewt-nimble/pull/487#discussion_r294099225
 
 

 ##########
 File path: nimble/controller/src/ble_ll_adv.c
 ##########
 @@ -2425,6 +2436,17 @@ ble_ll_adv_sm_stop_periodic(struct ble_ll_adv_sm *advsm)
         return;
     }
 
+    /*
+     * The Advertising DID is not required to change when a SyncInfo field is
+     * added to or removed from an advertising set. However, if it does not
+     * change, then scanners may fail to synchronize to periodic advertising
+     * because entries in the Advertising DID cache (see Section 4.3.3) mean
+     * they ignore the advertisements containing the SyncInfo field. Therefore,
+     * advertisers should update the Advertising DID when a periodic advertising
+     * train is enabled.
+     */
+    ble_ll_adv_update_did(advsm);
 
 Review comment:
   I'll update comment in disable section, but I think it is useful, cause remote scanner might be notified about no sync available before issuing Create Sync (which could not be a case if it was filtering duplicates)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services