You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by nj...@apache.org on 2016/06/17 07:26:08 UTC

[1/3] kylin git commit: Change the taskThreadCount from 4 to 8

Repository: kylin
Updated Branches:
  refs/heads/1.4-rc e3cbbcf13 -> d138d174d


Change the taskThreadCount from 4 to 8


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/58724471
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/58724471
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/58724471

Branch: refs/heads/1.4-rc
Commit: 587244713e66b8392f6e91c4c3a69e65f4601998
Parents: e3cbbcf
Author: kyotoYaho <nj...@apache.org>
Authored: Fri Jun 17 15:23:24 2016 +0800
Committer: kyotoYaho <nj...@apache.org>
Committed: Fri Jun 17 15:23:24 2016 +0800

----------------------------------------------------------------------
 .../apache/kylin/cube/inmemcubing/AbstractInMemCubeBuilder.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/58724471/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/AbstractInMemCubeBuilder.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/AbstractInMemCubeBuilder.java b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/AbstractInMemCubeBuilder.java
index e5bff30..3997e94 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/AbstractInMemCubeBuilder.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/AbstractInMemCubeBuilder.java
@@ -41,7 +41,7 @@ abstract public class AbstractInMemCubeBuilder {
     final protected CubeDesc cubeDesc;
     final protected Map<TblColRef, Dictionary<?>> dictionaryMap;
 
-    protected int taskThreadCount = 4;
+    protected int taskThreadCount = 8;
     protected int reserveMemoryMB = 100;
 
     public AbstractInMemCubeBuilder(CubeDesc cubeDesc, Map<TblColRef, Dictionary<?>> dictionaryMap) {


[2/3] kylin git commit: Modify the log info

Posted by nj...@apache.org.
Modify the log info


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/7b80edb1
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/7b80edb1
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/7b80edb1

Branch: refs/heads/1.4-rc
Commit: 7b80edb1b79272bdb9cd26bbb576f13bcb9c38c4
Parents: 5872447
Author: kyotoYaho <nj...@apache.org>
Authored: Fri Jun 17 15:24:16 2016 +0800
Committer: kyotoYaho <nj...@apache.org>
Committed: Fri Jun 17 15:24:16 2016 +0800

----------------------------------------------------------------------
 .../src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java   | 3 ++-
 .../org/apache/kylin/metadata/filter/ConstantTupleFilter.java   | 5 -----
 2 files changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/7b80edb1/core-cube/src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java b/core-cube/src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java
index 990cf06..3f67213 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/kv/RowKeyEncoder.java
@@ -89,7 +89,8 @@ public class RowKeyEncoder extends AbstractRowKeyEncoder {
 
     @Override
     public void encode(ByteArray bodyBytes, ByteArray outputBuf) {
-        Preconditions.checkState(bodyBytes.length() == bodyLength);
+        Preconditions.checkState(bodyBytes.length() == bodyLength,//
+                "bodybytes length: " + bodyBytes.length() + " merged body length: " + bodyLength);
         Preconditions.checkState(bodyBytes.length() + getHeaderLength() == outputBuf.length(),//
                 "bodybytes length: " + bodyBytes.length() + " outputBuf length: " + outputBuf.length() + " header length: " + getHeaderLength());
         System.arraycopy(bodyBytes.array(), bodyBytes.offset(), outputBuf.array(), getHeaderLength(), bodyLength);

http://git-wip-us.apache.org/repos/asf/kylin/blob/7b80edb1/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java
index a92c699..0246e08 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/ConstantTupleFilter.java
@@ -101,13 +101,8 @@ public class ConstantTupleFilter extends TupleFilter {
                 buffer = ByteBuffer.allocate(bufferSize);
                 int size = this.constantValues.size();
                 BytesUtil.writeVInt(size, buffer);
-                logger.info("constantValues.size: {}", size);
                 for (Object val : this.constantValues) {
-                    if(! (val instanceof String)){
-                        logger.error("Problematic constant value:" + val);
-                    }
                     cs.serialize(val, buffer);
-                    logger.info("Buffer Position: {}", buffer.position());
                 }
                 break;
             }catch (BufferOverflowException e) {


[3/3] kylin git commit: KYLIN-1189: Keep the status of pending jobs to be READY

Posted by nj...@apache.org.
KYLIN-1189: Keep the status of pending jobs to be READY


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/d138d174
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/d138d174
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/d138d174

Branch: refs/heads/1.4-rc
Commit: d138d174d2473648cf5e706e30e14efcace41d26
Parents: 7b80edb
Author: kyotoYaho <nj...@apache.org>
Authored: Fri Jun 17 15:25:14 2016 +0800
Committer: kyotoYaho <nj...@apache.org>
Committed: Fri Jun 17 15:25:14 2016 +0800

----------------------------------------------------------------------
 .../org/apache/kylin/job/impl/threadpool/DefaultScheduler.java  | 5 -----
 1 file changed, 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/d138d174/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
----------------------------------------------------------------------
diff --git a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
index 4abaa23..2915c60 100644
--- a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
+++ b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
@@ -170,11 +170,6 @@ public class DefaultScheduler implements Scheduler<AbstractExecutable>, Connecti
         jobPool = new ThreadPoolExecutor(corePoolSize, corePoolSize, Long.MAX_VALUE, TimeUnit.DAYS, new SynchronousQueue<Runnable>());
         context = new DefaultContext(Maps.<String, Executable> newConcurrentMap(), jobEngineConfig.getConfig());
 
-        for (AbstractExecutable executable : executableManager.getAllExecutables()) {
-            if (executable.getStatus() == ExecutableState.READY) {
-                executableManager.updateJobOutput(executable.getId(), ExecutableState.ERROR, null, "scheduler initializing work to reset job to ERROR status");
-            }
-        }
         executableManager.resumeAllRunningJobs();
 
         Runtime.getRuntime().addShutdownHook(new Thread() {