You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/07/16 15:12:49 UTC
Review Request 71083: Added enchanced multi-role capability support
to the python bindings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71083/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Meng Zhu.
Bugs: MESOS-9864
https://issues.apache.org/jira/browse/MESOS-9864
Repository: mesos
Description
-------
This patch adds suppressed roles list to the arguments of the scheduler
driver constructor and `revivieOffers()`/`suppressOffers` methods, and
also adds support of the `updateFramework()` method.
Diffs
-----
src/python/interface/src/mesos/interface/__init__.py 1200ef652f6458b9bbcd29b4d93d34c28230c7d0
src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.hpp 8c98d46fb842595956d58a3f91f805e44be2bcf2
src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 6dec9daa295cfc67176fb043322b8e98efdd7d4b
Diff: https://reviews.apache.org/r/71083/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 71083: Added enchanced multi-role capability
support to the python bindings.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71083/#review216740
-----------------------------------------------------------
Looks good, can you update the 'Testing Done'? Were you at least able to manually test these calls?
- Benjamin Mahler
On July 16, 2019, 3:12 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71083/
> -----------------------------------------------------------
>
> (Updated July 16, 2019, 3:12 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9864
> https://issues.apache.org/jira/browse/MESOS-9864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds suppressed roles list to the arguments of the scheduler
> driver constructor and `revivieOffers()`/`suppressOffers` methods, and
> also adds support of the `updateFramework()` method.
>
>
> Diffs
> -----
>
> src/python/interface/src/mesos/interface/__init__.py 1200ef652f6458b9bbcd29b4d93d34c28230c7d0
> src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.hpp 8c98d46fb842595956d58a3f91f805e44be2bcf2
> src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 6dec9daa295cfc67176fb043322b8e98efdd7d4b
>
>
> Diff: https://reviews.apache.org/r/71083/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 71083: Added enchanced multi-role capability
support to the python bindings.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71083/#review216819
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 23, 2019, 4:27 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71083/
> -----------------------------------------------------------
>
> (Updated July 23, 2019, 4:27 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9864
> https://issues.apache.org/jira/browse/MESOS-9864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds suppressed roles list to the arguments of the scheduler
> driver constructor and `revivieOffers()`/`suppressOffers` methods, and
> also adds support of the `updateFramework()` method.
>
>
> Diffs
> -----
>
> src/python/interface/src/mesos/interface/__init__.py 1200ef652f6458b9bbcd29b4d93d34c28230c7d0
> src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.hpp 8c98d46fb842595956d58a3f91f805e44be2bcf2
> src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 6dec9daa295cfc67176fb043322b8e98efdd7d4b
>
>
> Diff: https://reviews.apache.org/r/71083/diff/2/
>
>
> Testing
> -------
>
> Unsuppressing via update: `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.PythonFramework*" --gtest_break_on_failure --gtest_repeat=50` with the changes from the dependent patch.
> revivie/suppress: tested manually.
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 71083: Added enchanced multi-role capability
support to the python bindings.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71083/
-----------------------------------------------------------
(Updated July 23, 2019, 4:27 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Bugs: MESOS-9864
https://issues.apache.org/jira/browse/MESOS-9864
Repository: mesos
Description
-------
This patch adds suppressed roles list to the arguments of the scheduler
driver constructor and `revivieOffers()`/`suppressOffers` methods, and
also adds support of the `updateFramework()` method.
Diffs (updated)
-----
src/python/interface/src/mesos/interface/__init__.py 1200ef652f6458b9bbcd29b4d93d34c28230c7d0
src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.hpp 8c98d46fb842595956d58a3f91f805e44be2bcf2
src/python/scheduler/src/mesos/scheduler/mesos_scheduler_driver_impl.cpp 6dec9daa295cfc67176fb043322b8e98efdd7d4b
Diff: https://reviews.apache.org/r/71083/diff/2/
Changes: https://reviews.apache.org/r/71083/diff/1-2/
Testing (updated)
-------
Unsuppressing via update: `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.PythonFramework*" --gtest_break_on_failure --gtest_repeat=50` with the changes from the dependent patch.
revivie/suppress: tested manually.
Thanks,
Andrei Sekretenko