[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3116: Cleanup parquet tests

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #3116:
URL: https://github.com/apache/arrow-rs/pull/3116#discussion_r1029077037


##########
parquet/src/file/writer.rs:
##########
@@ -1212,16 +1231,19 @@ mod tests {
         for (i, item) in data.iter().enumerate().take(reader.num_row_groups()) {
             let row_group_reader = reader.get_row_group(i).unwrap();
             let iter = row_group_reader.get_row_iter(None).unwrap();
-            let res = iter
-                .map(|elem| elem.get_int(0).unwrap())
-                .collect::<Vec<i32>>();
+            let res: Vec<_> = iter.map(&value).collect();
             assert_eq!(res, *item);
         }
         file_metadata
     }
 
-    fn assert_send<T: Send>(t: T) -> T {

Review Comment:
   Yes, all the async plumbing requires it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org