[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #242: fMinor Improvements:

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #242:
URL: https://github.com/apache/httpcomponents-core/pull/242#discussion_r551548523



##########
File path: httpcore5/src/main/java/org/apache/hc/core5/util/Deadline.java
##########
@@ -58,12 +58,12 @@
     /**
      * The maximum (longest-lived) deadline.
      */
-    public static Deadline MAX_VALUE = new Deadline(INTERNAL_MAX_VALUE);
+    public static final Deadline MAX_VALUE = new Deadline(INTERNAL_MAX_VALUE);
 
     /**
      * The minimum (shortest-lived) deadline.
      */
-    public static Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE);
+    public static final Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE);

Review comment:
       @arturobernalg Same problem as before. This will likely break binary compatibility with previous 5.x releases.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org