You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by oliversalzburg <gi...@git.apache.org> on 2015/01/27 09:45:31 UTC
[GitHub] cordova-wp8 pull request: Removed ConsoleHelper from VS Project Te...
GitHub user oliversalzburg opened a pull request:
https://github.com/apache/cordova-wp8/pull/73
Removed ConsoleHelper from VS Project Template
It is not clear what the intent or benefit of the code is at this point. Identical functionality is provided by cordova-plugin-console.
@purplecabbage You contributed both `ConsoleHelper.cs` here and `DebugConsole.cs` in cordova-plugin-console, maybe you can shed some light on this?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hartwig-cordova/cordova-wp8 fix/consolehelper
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-wp8/pull/73.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #73
----
commit da2d73e20f15bf214d074129147c90622bd67939
Author: Oliver Salzburg <ol...@gmail.com>
Date: 2015-01-27T08:43:46Z
Removed ConsoleHelper from VS Project Template
It is not clear what the intent or benefit of the code is at this point. Identical functionality is provided by cordova-plugin-console.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Removed ConsoleHelper from VS Project Te...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/73#issuecomment-71616866
I'll add a comment to the code to make it more obvious. Sorry for not doing this sooner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Removed ConsoleHelper from VS Project Te...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/73#issuecomment-71615144
console.log is expected intrinsic browser behavior and should exist without needing to install a plugin.
The default template cordova application even has console.log calls in it, further confusing developers if they never surface anywhere. This is why I added minimal console.log support to the platform directly.
The same goes for XMLHttpRequest support via XHRHelper; Developers shouldn't need to install a plugin to get baseline XHR functionality that should exist out of the box.
The plugin cordova-plugin-console is place to supplement console support by overriding the 'platform' implementation.
I would recommend you not waste time deleting this, and focus instead on making cordova-plugin-console better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Removed ConsoleHelper from VS Project Te...
Posted by oliversalzburg <gi...@git.apache.org>.
Github user oliversalzburg closed the pull request at:
https://github.com/apache/cordova-wp8/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Removed ConsoleHelper from VS Project Te...
Posted by oliversalzburg <gi...@git.apache.org>.
Github user oliversalzburg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/73#issuecomment-71616569
Thanks. If only there was a way to communicate intent of code, then I would not have wasted any time in the first place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org