[GitHub] [kafka] ableegoldman commented on pull request #11686: KAFKA-12648: invoke exception handler for MissingSourceTopicException with named topologies

[GitBox <gi...@apache.org>]

ableegoldman commented on pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#issuecomment-1017267616


   > Although there is a commit that says "exclude topologies with missing source topics from assignment" I could not find where the topologies are excluded from the assignment.
   
   @cadonna ah, that commit was actually from the [first PR](https://github.com/apache/kafka/pull/11600), I think it's just a relic of how I did this PR on top of that one and rebased it. Sorry for the confusion.
   
   Otherwise I believe I've addressed all your feedback, I did need to do a bit of refactoring for [this ](https://github.com/apache/kafka/pull/11686#discussion_r788430597) but it's ultimately a small technical difference -- please lmk if there's anything else, otherwise I'll merge if the build is green tomorrow
   
   Thanks for the reviews!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org