[GitHub] [samza] prateekm commented on a change in pull request #1004: Preventing task-shuffle after task mode addition

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1004: Preventing task-shuffle after task mode addition
URL: https://github.com/apache/samza/pull/1004#discussion_r277038758
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala
 ##########
 @@ -122,9 +122,9 @@ object JobModelManager extends Logging {
     val processorLocality: util.Map[String, LocationId] = getProcessorLocality(config, localityManager)
     val taskModes: util.Map[TaskName, TaskMode] = taskAssignmentManager.readTaskModes()
 
-    // We read the taskAssignment only for ActiveTasks
+    // We read the taskAssignment only for ActiveTasks, i.e., tasks that have no task-mode or have an active task mode
 
 Review comment:
   Is it true that after upgrading to 1.1 every task will have the task mode? Or is mode only set if standby containers are enabled? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services