[GitHub] [arrow-datafusion] berkaysynnada commented on pull request #5764: Support timestamp and interval arithmetic

["berkaysynnada (via GitHub)" <gi...@apache.org>]

berkaysynnada commented on PR #5764:
URL: https://github.com/apache/arrow-datafusion/pull/5764#issuecomment-1489784338

   > First of all, thank you so much @berkaysynnada
   > 
   > I think this is a significant improvement to DataFusion -- while longer term I would prefer to see the interval arithmetic logic moved into arrow-rs, starting with an implementation in the DataFusion repo has worked well in the past and I think will work well here too.
   > 
   > Can you please respond to @tustvold 's comments? I think they are good questions, but then I think we could merge this PR and file a follow on tickets
   > 
   > 1. Move the arithmetic code into binary.rs (following the existing models, as a step towards getting them upstream in arrow).
   > 2. File a ticket about not handling timezones properly
   > 
   > cc @waitingkuo @avantgardnerio @andygrove @liukun4515
   
   I am working on @tustvold 's comments, and when I finalize them I will commit. Thanks for the support of `try_binary`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org