You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/08/05 16:00:20 UTC
Review Request 37132: Handle !p for password in commands when run
using sudo=True
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37132/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-12649
https://issues.apache.org/jira/browse/AMBARI-12649
Repository: ambari
Description
-------
Passwords are visible in plain text in install logs. As per aonishuk, such
cases needs to be taken care of in a generic way.
Reference : <https://github.com/apache/ambari/commit/36b89a16a368ff254004529d8
0bf003ceae523bb>
Diffs
-----
ambari-agent/src/test/python/resource_management/TestMonitorWebserverResource.py 5cd55a8
ambari-common/src/main/python/resource_management/core/base.py b291769
ambari-common/src/main/python/resource_management/core/logger.py f3ea4e9
ambari-common/src/main/python/resource_management/core/utils.py d9f678b
ambari-common/src/main/python/resource_management/libraries/functions/format.py 6fdecc0
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 71996d2
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 6f6a02b
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 2551ccd
Diff: https://reviews.apache.org/r/37132/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 37132: Handle !p for password in commands when run
using sudo=True
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37132/#review94247
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Aug. 5, 2015, 2:01 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37132/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 2:01 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-12649
> https://issues.apache.org/jira/browse/AMBARI-12649
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Passwords are visible in plain text in install logs. such
> cases needs to be taken care of in a generic way.
> Reference : <https://github.com/apache/ambari/commit/36b89a16a368ff254004529d8
> 0bf003ceae523bb>
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestMonitorWebserverResource.py 5cd55a8
> ambari-common/src/main/python/resource_management/core/base.py b291769
> ambari-common/src/main/python/resource_management/core/logger.py f3ea4e9
> ambari-common/src/main/python/resource_management/core/utils.py d9f678b
> ambari-common/src/main/python/resource_management/libraries/functions/format.py 6fdecc0
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 71996d2
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 6f6a02b
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 2551ccd
>
> Diff: https://reviews.apache.org/r/37132/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 37132: Handle !p for password in commands when run
using sudo=True
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37132/
-----------------------------------------------------------
(Updated Aug. 5, 2015, 2:01 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-12649
https://issues.apache.org/jira/browse/AMBARI-12649
Repository: ambari
Description (updated)
-------
Passwords are visible in plain text in install logs. such
cases needs to be taken care of in a generic way.
Reference : <https://github.com/apache/ambari/commit/36b89a16a368ff254004529d8
0bf003ceae523bb>
Diffs
-----
ambari-agent/src/test/python/resource_management/TestMonitorWebserverResource.py 5cd55a8
ambari-common/src/main/python/resource_management/core/base.py b291769
ambari-common/src/main/python/resource_management/core/logger.py f3ea4e9
ambari-common/src/main/python/resource_management/core/utils.py d9f678b
ambari-common/src/main/python/resource_management/libraries/functions/format.py 6fdecc0
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py 71996d2
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 6f6a02b
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 2551ccd
Diff: https://reviews.apache.org/r/37132/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk