[GitHub] [dolphinscheduler] shangeyao commented on a diff in pull request #10834: [Fix-10595][api] Fix Dependent Node Only View Projects Created By Self

[GitBox <gi...@apache.org>]

shangeyao commented on code in PR #10834:
URL: https://github.com/apache/dolphinscheduler/pull/10834#discussion_r915727126


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProjectMapper.xml:
##########
@@ -163,11 +163,9 @@
     <select id="queryAllProject" resultType="org.apache.dolphinscheduler.dao.entity.Project">
         select
         <include refid="baseSql"/>
-        from t_ds_project
-        where 1=1
-        <if test="userId != 0">
-            and user_id = #{userId}
-        </if>
+        from t_ds_project p
+        right join t_ds_relation_project_user rpu on p.id = rpu.project_id
+        where rpu.user_id = #{userId}

Review Comment:
   i correct it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org