You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/11 00:24:37 UTC
[GitHub] [netbeans] swpalmer opened a new pull request, #5268: RunSingle conditionally calls setMain(...) or getMainClass().set(...)…
swpalmer opened a new pull request, #5268:
URL: https://github.com/apache/netbeans/pull/5268
… based on Gradle version
Addresses Issue #5267
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] swpalmer commented on pull request #5268: RunSingle conditionally calls setMain(...) or getMainClass().set(...)…
Posted by GitBox <gi...@apache.org>.
swpalmer commented on PR #5268:
URL: https://github.com/apache/netbeans/pull/5268#issuecomment-1378823437
@lkishalmi Yes, go with yours. I actually had made changes to mine to be more like yours, but I was bitten by Git's horrible UI and the old changes were committed accidentally!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #5268: RunSingle conditionally calls setMain(...) or getMainClass().set(...)…
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #5268:
URL: https://github.com/apache/netbeans/pull/5268#issuecomment-1378296677
@swpalmer First, thank you for reporting this issue and the PR as well.
If you do not mind, I'd prefer mine instead as, the `mainClass` property was introduced in Gradle 6.4, got deprecated in 7.1 and removed in 8.0.
So mine version would remove the warning message from [7.1-8.0) versions...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5268: RunSingle conditionally calls setMain(...) or getMainClass().set(...)…
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5268:
URL: https://github.com/apache/netbeans/pull/5268#issuecomment-1378280567
oops. @lkishalmi has a similar PR here: #5269
I let you two to fight this out :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi closed pull request #5268: RunSingle conditionally calls setMain(...) or getMainClass().set(...)…
Posted by GitBox <gi...@apache.org>.
lkishalmi closed pull request #5268: RunSingle conditionally calls setMain(...) or getMainClass().set(...)…
URL: https://github.com/apache/netbeans/pull/5268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists