svn commit: r1499269 - /sling/whiteboard/fmeschbe/deprecate_login_administrative/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryImpl.java

[fm...@apache.org]

Author: fmeschbe
Date: Wed Jul  3 08:51:05 2013
New Revision: 1499269

URL: http://svn.apache.org/r1499269
Log:
Implement support for service based ResourceResolver and Session access

- Clarify what happens if no service user is available: Currently
  a ResourceResolver is not generated to err on the safe side if
  the configuration is insufficient.

Modified:
    sling/whiteboard/fmeschbe/deprecate_login_administrative/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryImpl.java

Modified: sling/whiteboard/fmeschbe/deprecate_login_administrative/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryImpl.java
URL: http://svn.apache.org/viewvc/sling/whiteboard/fmeschbe/deprecate_login_administrative/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryImpl.java?rev=1499269&r1=1499268&r2=1499269&view=diff
==============================================================================
--- sling/whiteboard/fmeschbe/deprecate_login_administrative/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryImpl.java (original)
+++ sling/whiteboard/fmeschbe/deprecate_login_administrative/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryImpl.java Wed Jul  3 08:51:05 2013
@@ -86,7 +86,11 @@ public class ResourceResolverFactoryImpl
             serviceInfo = null;
         }
 
-        // Ensure a mapped user name ... TODO: may this be null ??
+        // Ensure a mapped user name: If no user is defined for a bundle
+        // acting as a service, the user may be null. We can decide whether
+        // this should yield guest access or no access at all. For now
+        // no access is granted if there is no service user defined for
+        // the bundle.
         final String userName = this.serviceUserMapper.getUserForService(this.usingBundle, serviceInfo);
         if (userName == null) {
             throw new LoginException("Cannot derive user name for service "