[GitHub] [incubator-doris] HappenLee commented on a change in pull request #7181: [Bug] Fix mem limit -1 in partition aggregate node

[GitBox <gi...@apache.org>]

HappenLee commented on a change in pull request #7181:
URL: https://github.com/apache/incubator-doris/pull/7181#discussion_r754773344



##########
File path: be/src/exec/partitioned_aggregation_node.cc
##########
@@ -849,7 +849,7 @@ Status PartitionedAggregationNode::Partition::Spill(bool more_aggregate_rows) {
     // TODO(ml): enable spill
     std::stringstream msg;
     msg << "New partitioned Aggregation in spill";
-    LIMIT_EXCEEDED(parent->mem_tracker(), parent->state_, msg.str());
+    LIMIT_EXCEEDED(parent->state_->query_mem_tracker(), parent->state_, msg.str());

Review comment:
       `instance_mem_tracker()` do not have mem limit so the limit of `instance_mem_tracker`  is -1. `instanc_mem_tracker` is child of `query_mem_tracker()` which have real limit number




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org