You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 19:11:53 UTC
[GitHub] [arrow] ggodik opened a new pull request, #13767: ARROW-17274: [GO] Remove panic from parquet.file.RowGroupReader.Column(index int)
ggodik opened a new pull request, #13767:
URL: https://github.com/apache/arrow/pull/13767
Remove panic from `parquet.file.RowGroupReader.Column(index int)`
- parquet.file.RowGroupReader.Column(index int) panics if the the provided column index is invalid.
- Return an error as the rest of the functions in the codebase return an error as well. For example GetColumnPageReader returns (PageReader, error)
- fixed usage in tests
https://github.com/apache/arrow/blob/master/go/parquet/file/row_group_reader.go#L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13767: ARROW-17274: [GO] Remove panic from parquet.file.RowGroupReader.Column(index int)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13767:
URL: https://github.com/apache/arrow/pull/13767#issuecomment-1201818720
Benchmark runs are scheduled for baseline = 877ed5b0817df5d2592b92964c647714c04f417f and contender = c5173186bbd61641ba05e2848ad860fb696f6095. c5173186bbd61641ba05e2848ad860fb696f6095 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d5086255ecfb4d40aa132d66aa38d46a...1641f52afad441bd8510d081cf990d39/)
[Finished :arrow_down:0.03% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/bebed233c43b49b0ad98c1ea39a2907d...bc35e07e998744b6a92bbb19bc9f5c5d/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/52ddcadae14e4989aa2efa1e6ce6fe06...d9f215d600eb4ed3a5646423ec20b526/)
[Finished :arrow_down:0.11% :arrow_up:0.32%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/173c095c27334253b48eea7fd8d4ef1b...2cec65892d1a42278c08acf9bea4bdf0/)
Buildkite builds:
[Failed] [`c5173186` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1236)
[Finished] [`c5173186` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1248)
[Finished] [`c5173186` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1230)
[Finished] [`c5173186` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1250)
[Failed] [`877ed5b0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1235)
[Finished] [`877ed5b0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1247)
[Finished] [`877ed5b0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1229)
[Finished] [`877ed5b0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1249)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13767: ARROW-17274: [GO] Remove panic from parquet.file.RowGroupReader.Column(index int)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13767:
URL: https://github.com/apache/arrow/pull/13767#issuecomment-1201603320
https://issues.apache.org/jira/browse/ARROW-17274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13767: ARROW-17274: [GO] Remove panic from parquet.file.RowGroupReader.Column(index int)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13767:
URL: https://github.com/apache/arrow/pull/13767#issuecomment-1201603399
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #13767: ARROW-17274: [GO] Remove panic from parquet.file.RowGroupReader.Column(index int)
Posted by GitBox <gi...@apache.org>.
zeroshade merged PR #13767:
URL: https://github.com/apache/arrow/pull/13767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #13767: ARROW-17274: [GO] Remove panic from parquet.file.RowGroupReader.Column(index int)
Posted by GitBox <gi...@apache.org>.
zeroshade commented on PR #13767:
URL: https://github.com/apache/arrow/pull/13767#issuecomment-1201637223
+1 assuming all the tests succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org