[jira] [Commented] (YARN-5472) WIN_MAX_PATH logic is off by one

["Daniel Templeton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412163#comment-15412163 ] 

Daniel Templeton commented on YARN-5472:
----------------------------------------

It would appear you are correct.  Have you tested it to confirm?

> WIN_MAX_PATH logic is off by one
> --------------------------------
>
>                 Key: YARN-5472
>                 URL: https://issues.apache.org/jira/browse/YARN-5472
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.6.0
>         Environment: Windows
>            Reporter: Brook Zhou
>            Assignee: Brook Zhou
>            Priority: Minor
>         Attachments: YARN-5472-v0.patch
>
>
> The following check is incorrect in DefaultContainerExecutor:
>     if (Shell.WINDOWS && sb.getWrapperScriptPath().toString().length() >     WIN_MAX_PATH)
> should be >=, as the max path is defined as "D:\some 256-character path string<NUL>" on Windows platforms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org