You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/01 09:00:44 UTC

[GitHub] [inlong] thesumery commented on a diff in pull request #5763: [INLONG-5762][Sort] Fix pulsar source metric computing

thesumery commented on code in PR #5763:
URL: https://github.com/apache/inlong/pull/5763#discussion_r960400066


##########
inlong-sort/sort-connectors/pulsar/src/main/java/org/apache/inlong/sort/pulsar/table/DynamicPulsarDeserializationSchema.java:
##########
@@ -132,6 +140,39 @@ public void open(DeserializationSchema.InitializationContext context) throws Exc
 
     }
 
+    /**
+     * reflect get metricGroup
+     *
+     * @param context
+     * @return
+     */
+    private MetricGroup getMetricGroup(DeserializationSchema.InitializationContext context)

Review Comment:
   Why not modify FlinkPulsarSource#open directly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org