You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2025/07/26 15:31:57 UTC

[PR] [SPARK-52964] Add `merge_connect_rust_pr.py` and `PULL_REQUEST_TEMPLATE` [spark-connect-rust]

sarutak opened a new pull request, #3:
URL: https://github.com/apache/spark-connect-rust/pull/3

   # Description
   
   This PR proposes adding `merge_connect_rust_pr.py` and `PULL_REQUEST_TEMPLATE` like the Spark repository does.
   These files are brought from Spark repository and tweaked. The diffs are:
   
   * `diff spark-connect-rust/dev/merge_connect_rust_pr.py spark/dev/merge_spark_pr.py`
   ```
   > # Location of your Spark git development area
   > SPARK_HOME = os.environ.get("SPARK_HOME", os.getcwd())
   65,66c67,68
   < GITHUB_BASE = "https://github.com/apache/spark-connect-rust/pull"
   < GITHUB_API_BASE = "https://api.github.com/repos/apache/spark-connect-rust"
   ---
   > GITHUB_BASE = "https://github.com/apache/spark/pull"
   > GITHUB_API_BASE = "https://api.github.com/repos/apache/spark"
   602a605
   >     os.chdir(SPARK_HOME)
   ```
   
   * `diff spark-connect-rust/.github/PULL_REQUEST_TEMPLATE spark/.github/PULL_REQUEST_TEMPLATE`
   ```
   >   7. If you want to add a new configuration, please read the guideline first for naming configurations in
   >      'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   >   8. If you want to add or modify an error type or message, please read the guideline first in
   >      'common/utils/src/main/resources/error/README.md'.
   44a49
   > If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   ```
   
   I confirmed this script works by:
   
   1. Changing the script to direct my own repository instead of Apache's one like as follows and push this change to my master branch.
   ```
   --- a/dev/merge_connect_rust_pr.py
   +++ b/dev/merge_connect_rust_pr.py
   @@ -43,9 +43,9 @@ except ImportError:
        JIRA_IMPORTED = False
    
    # Remote name which points to the Github site
   -PR_REMOTE_NAME = os.environ.get("PR_REMOTE_NAME", "apache-github")
   +PR_REMOTE_NAME = os.environ.get("PR_REMOTE_NAME", "sarutak-github")
    # Remote name which points to Apache git
   -PUSH_REMOTE_NAME = os.environ.get("PUSH_REMOTE_NAME", "apache")
   +PUSH_REMOTE_NAME = os.environ.get("PUSH_REMOTE_NAME", "sarutak")
    # ASF JIRA username
    JIRA_USERNAME = os.environ.get("JIRA_USERNAME", "")
    # ASF JIRA password
   @@ -62,8 +62,8 @@ JIRA_ACCESS_TOKEN = os.environ.get("JIRA_ACCESS_TOKEN")
    GITHUB_OAUTH_KEY = os.environ.get("GITHUB_OAUTH_KEY")
    
    
   -GITHUB_BASE = "https://github.com/apache/spark-connect-rust/pull"
   -GITHUB_API_BASE = "https://api.github.com/repos/apache/spark-connect-rust"
   +GITHUB_BASE = "https://github.com/sarutak/spark-connect-rust/pull"
   +GITHUB_API_BASE = "https://api.github.com/repos/sarutak/spark-connect-rust"
    JIRA_BASE = "https://issues.apache.org/jira/browse"
    JIRA_API_BASE = "https://issues.apache.org/jira"
    # Prefix added to temporary branches
   ```
   
   2. Create a PR to my master branch
   3. Merge the PR using the script and the PR is automatically closed
   
   The commit log of the change merged by this script is like as follows.
   ```
   Author: Kousuke Saruta <sa...@amazon.co.jp>
   Date:   Sun Jul 27 00:01:14 2025 +0900
   
       Add test.txt (test for PR merge script)
       
       # Description
       test
       
       Closes #2 from sarutak/merge-test-pr.
       
       Authored-by: Kousuke Saruta <sa...@amazon.co.jp>
       Signed-off-by: Kousuke Saruta <sa...@amazon.co.jp>
   ```
   
   ## Related Issue(s)
   SPARK-52964
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-52964] Add `merge_connect_rust_pr.py` and `PULL_REQUEST_TEMPLATE` [spark-connect-rust]

Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #3:
URL: https://github.com/apache/spark-connect-rust/pull/3#issuecomment-3162174193

   @xuanyuanking Thank you for pointing it out. I'll update it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-52964] Add `merge_connect_rust_pr.py` and `PULL_REQUEST_TEMPLATE` [spark-connect-rust]

Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #3:
URL: https://github.com/apache/spark-connect-rust/pull/3#issuecomment-3163504800

   @xuanyuanking Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-52964] Add `merge_connect_rust_pr.py` and `PULL_REQUEST_TEMPLATE` [spark-connect-rust]

Posted by "xuanyuanking (via GitHub)" <gi...@apache.org>.
xuanyuanking merged PR #3:
URL: https://github.com/apache/spark-connect-rust/pull/3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-52964] Add `merge_connect_rust_pr.py` and `PULL_REQUEST_TEMPLATE` [spark-connect-rust]

Posted by "xuanyuanking (via GitHub)" <gi...@apache.org>.
xuanyuanking commented on PR #3:
URL: https://github.com/apache/spark-connect-rust/pull/3#issuecomment-3163041732

   @sarutak ah make sense. Then let's just not use the button after merging the merge_script. Thanks for the further check!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-52964] Add `merge_connect_rust_pr.py` and `PULL_REQUEST_TEMPLATE` [spark-connect-rust]

Posted by "xuanyuanking (via GitHub)" <gi...@apache.org>.
xuanyuanking commented on PR #3:
URL: https://github.com/apache/spark-connect-rust/pull/3#issuecomment-3161277161

   Thanks @sarutak for this change!
   Do we also need to disable the merge button here https://github.com/apache/spark-connect-rust/blob/master/.asf.yaml#L28? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-52964] Add `merge_connect_rust_pr.py` and `PULL_REQUEST_TEMPLATE` [spark-connect-rust]

Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #3:
URL: https://github.com/apache/spark-connect-rust/pull/3#issuecomment-3162194487

   @xuanyuanking I checked the way Spark, spark-connect-swift and spark-connect-go.
   
   * Spark: https://github.com/apache/spark/blob/master/.asf.yaml
   * Go: https://github.com/apache/spark-connect-go/blob/master/.asf.yaml
   * Swift: https://github.com/apache/spark-connect-swift/blob/main/.asf.yaml
   
   These all don't disable the merge button so how about leaving it as it is?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org