You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/05 15:46:54 UTC
[GitHub] [arrow-datafusion] matthewmturner opened a new pull request, #2162: Add delimiter for create external table
matthewmturner opened a new pull request, #2162:
URL: https://github.com/apache/arrow-datafusion/pull/2162
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2158
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2162: Add delimiter for create external table
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2162:
URL: https://github.com/apache/arrow-datafusion/pull/2162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2162: Add delimiter for create external table
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2162:
URL: https://github.com/apache/arrow-datafusion/pull/2162#issuecomment-1090575300
I don't think there is anything particularly controversial in this PR so merging it in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] matthewmturner commented on pull request #2162: Add delimiter for create external table
Posted by GitBox <gi...@apache.org>.
matthewmturner commented on PR #2162:
URL: https://github.com/apache/arrow-datafusion/pull/2162#issuecomment-1089090654
@houqp @yjshen @xudong963 @alamb PTAL at your earliest convenience :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] matthewmturner commented on pull request #2162: Add delimiter for create external table
Posted by GitBox <gi...@apache.org>.
matthewmturner commented on PR #2162:
URL: https://github.com/apache/arrow-datafusion/pull/2162#issuecomment-1089222911
Disregard...ill clean up conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2162: Add delimiter for create external table
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2162:
URL: https://github.com/apache/arrow-datafusion/pull/2162#issuecomment-1090666035
No worries -- I tend to batch review time so yours happened to be ready when my timeslice arrived
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] matthewmturner commented on pull request #2162: Add delimiter for create external table
Posted by GitBox <gi...@apache.org>.
matthewmturner commented on PR #2162:
URL: https://github.com/apache/arrow-datafusion/pull/2162#issuecomment-1090604636
@alamb Thank you. I wouldn't normally ping for review immediately after submitting like that - but was trying to demo something for someone that required the feature. Appreciate your responsiveness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org