You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "molcay (via GitHub)" <gi...@apache.org> on 2025/11/18 14:44:56 UTC
[PR] Fix the "Copy" button for the run config on DAG run details [airflow]
molcay opened a new pull request, #58433:
URL: https://github.com/apache/airflow/pull/58433
The copy button for the run config on the DAG run details page was not working properly. When you click it only copy the last config run.
After doing some research on this, I found out that there is a problem with the hook: useClipboard and I found an issue in their repository about a work around: https://github.com/chakra-ui/chakra-ui/issues/6759.
The possible solutions are like the following:
1. Upgrade the version (I did not test this, because I am not sure how it will be an easy with all dependency tree.
2. Apply the workaround (I tested this, and it looks like it is working)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the "Copy" button for the run config on DAG run details [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #58433: Fix the "Copy" button for the run config on DAG run details
URL: https://github.com/apache/airflow/pull/58433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the "Copy" button for the run config on DAG run details [airflow]
Posted by "molcay (via GitHub)" <gi...@apache.org>.
molcay commented on PR #58433:
URL: https://github.com/apache/airflow/pull/58433#issuecomment-3557560199
I was hesitant to try the version upgrade. I am not sure but I think we don't have any automated UI tests, right?
If I upgrade the version how can I check the upgrade is not breaking any other places?
Also, which version to upgrade? Currently;
- we have the ` "@chakra-ui/react": "2.4.2"` dependency which has the ` "@chakra-ui/hooks" "2.1.2"` dependency
To upgrade I will change the `@chakra-ui/react` version but which one? the latest version for the `v 2.x` is `2.10.9`. They also have `v3.x` but I think upgrading to the major version is a bit risky.
Which version would be our target? the latest version from the 2? or upgrade enough to fix this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the "Copy" button for the run config on DAG run details [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #58433:
URL: https://github.com/apache/airflow/pull/58433#issuecomment-3549369352
Actually let's update our chakra version. We should keep it up to date anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org