[GitHub] [calcite] chunweilei commented on a change in pull request #1825: [CALCITE-3817] VolcanoPlanner does not remove the entry in ruleNames when removing a rule

[GitBox <gi...@apache.org>]

chunweilei commented on a change in pull request #1825: [CALCITE-3817] VolcanoPlanner does not remove the entry in ruleNames when removing a rule
URL: https://github.com/apache/calcite/pull/1825#discussion_r383130171
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
 ##########
 @@ -239,8 +237,8 @@
 
   /** Maps rule classes to their name, to ensure that the names are unique and
    * conform to rules. */
-  private final SetMultimap<String, Class> ruleNames =
-      LinkedHashMultimap.create();
+  private final Map<String, RelOptRule> ruleNames = new HashMap<>();
 
 Review comment:
   No need to use ```LinkedHashMultimap``` because the key should be unique.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services