You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/12/14 10:01:36 UTC
Review Request 64600: Fixed handling of resource provider updates
without resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64600/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Joseph Wu.
Repository: mesos
Description
-------
On master failover the master might learn about a resource provider
without resources. This patch relaxes an assertion in the master
permitting this scenarios.
Diffs
-----
src/master/master.cpp 2f2608f5d1369971cabd0d69cb4f1a2aaea8c1dd
Diff: https://reviews.apache.org/r/64600/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 64600: Fixed handling of resource provider updates
without resources.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64600/#review193935
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 14, 2017, 10:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64600/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 10:01 a.m.)
>
>
> Review request for mesos, Jie Yu and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On master failover the master might learn about a resource provider
> without resources. This patch relaxes an assertion in the master
> permitting this scenarios.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2f2608f5d1369971cabd0d69cb4f1a2aaea8c1dd
>
>
> Diff: https://reviews.apache.org/r/64600/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64600: Fixed handling of resource provider updates
without resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64600/#review193807
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64600']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64600
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64600/logs/mesos-tests-stdout.log):
```
[ RUN ] SlaveTest.RunTaskGroupFailedSecretGeneration
[ OK ] SlaveTest.RunTaskGroupFailedSecretGeneration (222 ms)
[ RUN ] SlaveTest.RunTaskGroupInvalidExecutorSecret
[ OK ] SlaveTest.RunTaskGroupInvalidExecutorSecret (218 ms)
[ RUN ] SlaveTest.RunTaskGroupReferenceTypeSecret
[ OK ] SlaveTest.RunTaskGroupReferenceTypeSecret (235 ms)
[ RUN ] SlaveTest.RunTaskGroupGenerateSecretAfterShutdown
[ OK ] SlaveTest.RunTaskGroupGenerateSecretAfterShutdown (244 ms)
[ RUN ] SlaveTest.KillTaskGroupBetweenRunTaskParts
[ OK ] SlaveTest.KillTaskGroupBetweenRunTaskParts (204 ms)
[ RUN ] SlaveTest.KillQueuedTaskGroup
[ OK ] SlaveTest.KillQueuedTaskGroup (272 ms)
[ RUN ] SlaveTest.MaxCompletedExecutorsPerFrameworkFlag
[ OK ] SlaveTest.MaxCompletedExecutorsPerFrameworkFlag (964 ms)
[ RUN ] SlaveTest.ShutdownV0ExecutorIfItReregistersWithoutReconnect
[ OK ] SlaveTest.ShutdownV0ExecutorIfItReregistersWithoutReconnect (240 ms)
[ RUN ] SlaveTest.IgnoreV0ExecutorIfItReregistersWithoutReconnect
[ OK ] SlaveTest.IgnoreV0ExecutorIfItReregistersWithoutReconnect (241 ms)
[ RUN ] SlaveTest.BrowseExecutorSandboxByVirtualPath
[ OK ] SlaveTest.BrowseExecutorSandboxByVirtualPath (265 ms)
[ RUN ] SlaveTest.DisconnectedExecutorDropsMessages
[ OK ] SlaveTest.DisconnectedExecutorDropsMessages (272 ms)
[ RUN ] SlaveTest.ResourceProviderSubscribe
[ OK ] SlaveTest.ResourceProviderSubscribe (194 ms)
[ RUN ] SlaveTest.ResourceVersions
[ OK ] SlaveTest.ResourceVersions (164 ms)
[ RUN ] SlaveTest.ReconfigurationPolicy
[ OK ] SlaveTest.ReconfigurationPolicy (239 ms)
[ RUN ] SlaveTest.ResourceProviderReconciliation
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64600/logs/mesos-tests-stderr.log):
```
@ 00007FF79CA3A770 google::LogMessage::SendToLog
@ 00007FF79CA39F57 google::LogMessage::Flush
@ 00007FF79CA3BA91 google::LogMessageFatal::~LogMessageFatal
@ 00007FF79A95319C mesos::internal::slave::Slave::handleResourceProviderMessage
@ 00007FF79AAFE2C5 ??
@ 00007FF79A9EBAD8 std::_Invoker_functor::_Call<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,process::ProcessBase * __ptr64>
@ 00007FF79AA717C8 std::invoke<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,process::ProcessBase * __ptr64>
@ 00007FF79AA819CB lambda::internal::Partial<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,std::_Ph<1> >::invoke_expand<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,std::tuple<process::Future<mesos::internal::ResourceProvi
@ 00007FF79A9C7D2A )<process::ProcessBase * __ptr64
@ 00007FF79A9F212C std::_Invoker_functor::_Call<lambda::internal::Partial<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,std::_Ph<1> >,process::ProcessBase * __ptr64>
@ 00007FF79AA77C2C std::invoke<lambda::internal::Partial<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,std::_Ph<1> >,process::ProcessBase * __ptr64>
@ 00007FF79A9CFC91 )<lambda::internal::Partial<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,std::_Ph<1> >,process::ProcessBase * __ptr64
@ 00007FF79AB0C1E6 process::ProcessBase * __ptr64)>::CallableFn<lambda::internal::Partial<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,std::_Ph<1> > >::operator(
@ 00007FF79C52A1AD process::ProcessBase * __ptr64)>::operator(
@ 00007FF79C403289 process::ProcessBase::consume
@ 00007FF79C57E30A process::DispatchEvent::consume
@ 00007FF7989C43D7 process::ProcessBase::serve
@ 00007FF79C410F6B process::ProcessManager::resume
@ 00007FF79C51A9D1 ??
@ 00007FF79C4594B0 std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF79C4AEE50 std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF79C46826C std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Execute<0>
@ 00007FF79C56630A std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Run
@ 00007FF79C552D98 std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Go
@ 00007FF79C53AA7D std::_Pad::_Call_func
@ 00007FF79D6DC838 invoke_thread_procedure
@ 00007FF79D6DC2E1 __cdecl*)(void * __ptr64)
@ 00007FFD4B841FE4 BaseThreadInitThunk
@ 00007FFD4E3CEF91 RtlUserThreadStart
```
- Mesos Reviewbot Windows
On Dec. 14, 2017, 10:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64600/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 10:01 a.m.)
>
>
> Review request for mesos, Jie Yu and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On master failover the master might learn about a resource provider
> without resources. This patch relaxes an assertion in the master
> permitting this scenarios.
>
>
> Diffs
> -----
>
> src/master/master.cpp 2f2608f5d1369971cabd0d69cb4f1a2aaea8c1dd
>
>
> Diff: https://reviews.apache.org/r/64600/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>