You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/08/08 19:35:02 UTC

Review Request 71257: Defined constant `DEFAULT_WEIGHT`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71257/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Repository: mesos


Description
-------

A role's default weight == 1.0. This affects the sorting
precedence during resource allocation.


Diffs
-----

  src/master/allocator/mesos/sorter/drf/sorter.cpp 40397f7111d92dccecd15c9bc1ad7c45abbd850b 
  src/master/allocator/mesos/sorter/random/sorter.cpp b480aeee38f87dca852ad3c8f97bb4fe993ce068 
  src/master/constants.hpp 26afa356b7844b4ec6c2caeef33bd39c51148d5f 


Diff: https://reviews.apache.org/r/71257/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu

Re: Review Request 71257: Defined constant `DEFAULT_WEIGHT`.

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71257/#review217144
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Aug. 8, 2019, 7:35 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71257/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2019, 7:35 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A role's default weight == 1.0. This affects the sorting
> precedence during resource allocation.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/sorter/drf/sorter.cpp 40397f7111d92dccecd15c9bc1ad7c45abbd850b 
>   src/master/allocator/mesos/sorter/random/sorter.cpp b480aeee38f87dca852ad3c8f97bb4fe993ce068 
>   src/master/constants.hpp 26afa356b7844b4ec6c2caeef33bd39c51148d5f 
> 
> 
> Diff: https://reviews.apache.org/r/71257/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>