You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/21 10:13:12 UTC

[GitHub] [submarine] ByronHsu opened a new pull request #609: SUBMARINE-858. Implement log_param and log_metric for distributed scenarios

ByronHsu opened a new pull request #609:
URL: https://github.com/apache/submarine/pull/609


   ### What is this PR for?
   Implement the backbone of distributed model management sdk and provide an example.
    
   **Implement details:**
   1. Calling start(), ModelsClient will parse the worker_id + experiment_id and creates a Mlflow run.
   2. The Mlflow run name is worker_id, and the Mflow experiment name is experiment_id.
   3. Calling log_param() or log_metric(), their info will be directed to the Mlflow runs previously set.
   
   **I also wrote an example docker image to test and demo the function.**
   You can follow this instruction to try this new function. (**REMEMBER TO INSTALL LATEST PYSUBMARINE LOCALLY FIRST**)
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-858
   
   ### How should this be tested?
   Manually test by the example provided.
   
   ### Screenshots (if appropriate)
   
   https://www.loom.com/share/bc0e9db28a0243bdacb564aacef6306b
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu commented on pull request #609: SUBMARINE-858. Implement log_param and log_metric for distributed scenarios

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #609:
URL: https://github.com/apache/submarine/pull/609#issuecomment-864981611


   @jeff-901 Help me review the PR. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #609: SUBMARINE-858. Implement log_param and log_metric for distributed scenarios

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #609:
URL: https://github.com/apache/submarine/pull/609


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] jeff-901 commented on pull request #609: SUBMARINE-858. Implement log_param and log_metric for distributed scenarios

Posted by GitBox <gi...@apache.org>.
jeff-901 commented on pull request #609:
URL: https://github.com/apache/submarine/pull/609#issuecomment-865657656


   > @jeff-901 Help me review the PR. Thanks!
   
   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu closed pull request #609: SUBMARINE-858. Implement log_param and log_metric for distributed scenarios

Posted by GitBox <gi...@apache.org>.
ByronHsu closed pull request #609:
URL: https://github.com/apache/submarine/pull/609


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] ByronHsu commented on pull request #609: SUBMARINE-858. Implement log_param and log_metric for distributed scenarios

Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #609:
URL: https://github.com/apache/submarine/pull/609#issuecomment-864981611


   @jeff-901 Help me review the PR. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] jeff-901 commented on pull request #609: SUBMARINE-858. Implement log_param and log_metric for distributed scenarios

Posted by GitBox <gi...@apache.org>.
jeff-901 commented on pull request #609:
URL: https://github.com/apache/submarine/pull/609#issuecomment-865657656


   > @jeff-901 Help me review the PR. Thanks!
   
   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org