[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #503: HDDS-2850. Handle Create container use case in Recon.

[GitBox <gi...@apache.org>]

avijayanhwx commented on a change in pull request #503: HDDS-2850. Handle Create container use case in Recon.
URL: https://github.com/apache/hadoop-ozone/pull/503#discussion_r372784812
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
 ##########
 @@ -194,6 +194,18 @@ public ContainerInfo getContainer(final ContainerID containerID)
     return containerStateManager.getContainer(containerID);
   }
 
+  @Override
+  public boolean exists(ContainerID containerID) {
+    lock.lock();
 
 Review comment:
   Not sure. SCM ContainerManager has had a Reentrant lock from the first. I will investigate why it is not a RW lock, and create a new JIRA for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org