You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/07/12 17:57:55 UTC

Review Request 60812: SENTRY-1697: Deprecate feature flag for enabling notification log

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60812/
-----------------------------------------------------------

Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.


Bugs: SENTRY-1697
    https://issues.apache.org/jira/browse/SENTRY-1697


Repository: sentry


Description
-------

SENTRY-1697: Deprecate feature flag for enabling notification log


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 322197bd04754315d923563094bcade87510deec 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 193c6115bb9891ef8362a0b92c97feb50059f509 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java ba507523077f3205ada214eeaf88c22d45468019 


Diff: https://reviews.apache.org/r/60812/diff/1/


Testing
-------


Thanks,

Alexander Kolbasov


Re: Review Request 60812: SENTRY-1697: Deprecate feature flag for enabling notification log

Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60812/#review180345
-----------------------------------------------------------


Ship it!




Ship It!

- Vamsee Yarlagadda


On July 12, 2017, 5:57 p.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60812/
> -----------------------------------------------------------
> 
> (Updated July 12, 2017, 5:57 p.m.)
> 
> 
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1697
>     https://issues.apache.org/jira/browse/SENTRY-1697
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1697: Deprecate feature flag for enabling notification log
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 322197bd04754315d923563094bcade87510deec 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 193c6115bb9891ef8362a0b92c97feb50059f509 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java ba507523077f3205ada214eeaf88c22d45468019 
> 
> 
> Diff: https://reviews.apache.org/r/60812/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>


Re: Review Request 60812: SENTRY-1697: Deprecate feature flag for enabling notification log

Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60812/#review180342
-----------------------------------------------------------


Ship it!




Ship It!

- Na Li


On July 12, 2017, 5:57 p.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60812/
> -----------------------------------------------------------
> 
> (Updated July 12, 2017, 5:57 p.m.)
> 
> 
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1697
>     https://issues.apache.org/jira/browse/SENTRY-1697
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1697: Deprecate feature flag for enabling notification log
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 322197bd04754315d923563094bcade87510deec 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 193c6115bb9891ef8362a0b92c97feb50059f509 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java ba507523077f3205ada214eeaf88c22d45468019 
> 
> 
> Diff: https://reviews.apache.org/r/60812/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>


Re: Review Request 60812: SENTRY-1697: Deprecate feature flag for enabling notification log

Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60812/#review180344
-----------------------------------------------------------


Ship it!




Ship It!

- kalyan kumar kalvagadda


On July 12, 2017, 5:57 p.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60812/
> -----------------------------------------------------------
> 
> (Updated July 12, 2017, 5:57 p.m.)
> 
> 
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
> 
> 
> Bugs: SENTRY-1697
>     https://issues.apache.org/jira/browse/SENTRY-1697
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1697: Deprecate feature flag for enabling notification log
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 322197bd04754315d923563094bcade87510deec 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 193c6115bb9891ef8362a0b92c97feb50059f509 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java ba507523077f3205ada214eeaf88c22d45468019 
> 
> 
> Diff: https://reviews.apache.org/r/60812/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>