[jira] [Commented] (MAPREDUCE-4309) Make locatlity in YARN's container assignment and task scheduling pluggable for other deployment topology

["Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407705#comment-13407705 ] 

Tsz Wo (Nicholas), SZE commented on MAPREDUCE-4309:
---------------------------------------------------

Quick comments:
- It does not apply anymore.
{noformat}
$patch -p0 -i ~/Downloads/HADOOP-8474-ContainerAssignmentTaskScheduling-pluggable.patch 
patching file hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
Hunk #1 FAILED at 18.
Hunk #2 succeeded at 37 (offset 1 line).
Hunk #3 FAILED at 45.
Hunk #4 succeeded at 65 with fuzz 2 (offset 9 lines).
Hunk #5 succeeded at 80 (offset 9 lines).
Hunk #6 succeeded at 119 (offset 9 lines).
Hunk #7 succeeded at 161 (offset 9 lines).
Hunk #8 succeeded at 548 (offset 10 lines).
Hunk #9 FAILED at 633.
3 out of 9 hunks FAILED -- saving rejects to file hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java.rej
...
{noformat}
- Could we keep ScheduledRequests as an inner class of RMContainerAllocator, i.e. change it to public/protected/package-private static?  It will be easier to see the changes.
                
> Make locatlity in YARN's container assignment and task scheduling pluggable for other deployment topology
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4309
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4309
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: HADOOP-8474-ContainerAssignmentTaskScheduling-pluggable.patch
>
>
> There are several classes in YARN’s container assignment and task scheduling algorithms that relate to data locality which were updated to give preference to running a container on other locality besides node-local and rack-local (like nodegroup-local). This propose to make these data structure/algorithms pluggable, like: SchedulerNode, RMNodeImpl, etc. The inner class ScheduledRequests was made a package level class to it would be easier to create a subclass, ScheduledRequestsWithNodeGroup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira