You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/09/20 01:48:29 UTC
[GitHub] codecov-io edited a comment on issue #446: SCB-929 Concurrent error
in update resource APIs
codecov-io edited a comment on issue #446: SCB-929 Concurrent error in update resource APIs
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/446#issuecomment-423012144
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446?src=pr&el=h1) Report
> Merging [#446](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3404f76e89342c8291d4e18eea63a183e0afe567?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 59.74% 59.76% +0.01%
==========================================
Files 149 149
Lines 13167 13175 +8
==========================================
+ Hits 7867 7874 +7
- Misses 4729 4730 +1
Partials 571 571
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv) | `71.4% <100%> (-0.06%)` | :arrow_down: |
| [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.33% <66.66%> (+0.12%)` | :arrow_up: |
| [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `70.28% <84.61%> (+0.11%)` | :arrow_up: |
| [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.26% <87.5%> (-0.06%)` | :arrow_down: |
| [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446/diff?src=pr&el=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `81.57% <0%> (-2.64%)` | :arrow_down: |
| [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
| [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: |
| [server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=) | `81.81% <0%> (+9.09%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446?src=pr&el=footer). Last update [3404f76...b1cd3f6](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/446?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services