[GitHub] [knox] smolnar82 commented on a change in pull request #230: KNOX-2157 - Verifying the server's state in addition to PID check at gateway start and registering shutdown hook in order to stop the server gracefully.

[GitBox <gi...@apache.org>]

smolnar82 commented on a change in pull request #230: KNOX-2157 - Verifying the server's state in addition to PID check at gateway start and registering shutdown hook in order to stop the server gracefully.
URL: https://github.com/apache/knox/pull/230#discussion_r363677458
 
 

 ##########
 File path: gateway-release-common/home/bin/knox-functions.sh
 ##########
 @@ -250,6 +302,11 @@ function appStop {
      exit 1
    else
      rm -f "$APP_PID_FILE"
+
+     #TODO: due to the current way of shutting down the server the status has never been changed to STOPPED (STARTING seems to be not reliable either which is weird).
 
 Review comment:
   Added the above-mentioned shutdown hook and it's working like a charm.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services