You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/05/25 23:54:59 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #553: [YUNIKORN-1770] Avoid resource clone in Application.tryNodes()
pbacsko opened a new pull request, #553:
URL: https://github.com/apache/yunikorn-core/pull/553
### What is this PR for?
We can avoid cloning the Resource object in `Application.tryNodes()`. On a busy cluster where nodes are full, the "fit in" score calculation runs very often, resulting in allocating a lot of resource objects constantly.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1770
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #553: [YUNIKORN-1770] Avoid resource clone in Application.tryNodes()
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #553:
URL: https://github.com/apache/yunikorn-core/pull/553#issuecomment-1563791981
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#553](https://app.codecov.io/gh/apache/yunikorn-core/pull/553?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c1aea6d) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/94e6f2dc1c7bec29c4c43f08ef140d682a5ff64e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (94e6f2d) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
- Coverage 74.83% 74.81% -0.02%
==========================================
Files 70 70
Lines 11519 11523 +4
==========================================
+ Hits 8620 8621 +1
- Misses 2595 2597 +2
- Partials 304 305 +1
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `65.04% <100.00%> (ø)` | |
| [pkg/scheduler/objects/node.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `82.56% <100.00%> (+0.19%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-core/pull/553/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #553: [YUNIKORN-1770] Avoid resource clone in Application.tryNodes()
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #553: [YUNIKORN-1770] Avoid resource clone in Application.tryNodes()
URL: https://github.com/apache/yunikorn-core/pull/553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org